Irfan Alibay

Results 473 comments of Irfan Alibay
trafficstars

> Currently, I have to no time to look into this in great details. When we had the last round of nice feedback I had the feeling that the [current...

@orbeckst since cython 3.0 is still in alpha, I'm going to place this as a v2.1.0 milestone, we can shift as necessary.

> @orbeckst since cython 3.0 is still in alpha, I'm going to place this as a v2.1.0 milestone, we can shift as necessary. Moving this to 2.2.0 instead as cython...

Moving to 2.3.0 since cython 3.0 is still in alpha

Cython 3.0 is still in alpha, re-targetting 2.4.0.

I was originally thinking we could do the old bfactor trick for warnings, https://github.com/MDAnalysis/mdanalysis/blob/d5c7cb9a7807b06c169b418dd5c6c072c33580f5/package/MDAnalysis/core/topologyattrs.py#L361-L366 But I'm not sure we can suitably pass across the reader class to TopologyAttrs to specifically...

So I should ask here - the fact that both squash_by and change_squash exist just next to each other makes me wonder if there is a file format specific reason...

My 2 cents is that I really don't like things that automatically reformat code we write. This is purely a case of "I know better than the machine", is there...

yeah I can live with it being just a CI warning. Will it apply purely on the diff?

touched files would be fine, essentially if we can avoid it screaming at us every time about known cases where we've agreed we don't want to deal with it (assuming...