Irfan Alibay

Results 483 comments of Irfan Alibay
trafficstars

Should be all fixed now.

@zwsmith200 is this still something you are looking to contribute?

> We can have guards where the formatting is intentional I'm still not an amazing fan of `black` (I am less wary now that that formatting style documentation has improved...

I would however add here (for the @MDAnalysis/coredevs) that I would urge a discussion on priorities here. We have a lot of maintenance work to do, and many PRs that...

> Is it possible that you add a project-wide autoformatter settings, and then for all new PRs you ask people to a) run the formatter on the files they're changing...

> yes, please, `asel` ▶️ `selection` ? `asel` is an atomgroup right? `atomgroup` might be closer to what we do elsewhere?

@hmacdope isn't this a 3.0 targeted change? We wouldn't be able to merge it during the application period.

> Ah yes sorry I meant the deprecation warning part. Do we think that is suitable ? Sounds good to me!

@hmacdope I'm reopening to keep an issue to track the removal of asel - please do reclose if there's another one already.

@jaclark5 I've not forgotten about this, it's at the top of my review list over the next few days.