common-definitions icon indicating copy to clipboard operation
common-definitions copied to clipboard

Fix korea region

Open d3y419 opened this issue 11 months ago • 8 comments

South Korea was incorrectly categorized in a few models. I went through the list and fixed them.

d3y419 avatar Jan 23 '25 13:01 d3y419

@danielhuppmann please review.

d3y419 avatar Jan 23 '25 13:01 d3y419

Thank you - did you reach out to the teams that have the wrong mapping so that they are aware of the info? This might cause difference between legacy projects and newly submitted scenario.

danielhuppmann avatar Jan 23 '25 13:01 danielhuppmann

Thank you - did you reach out to the teams that have the wrong mapping so that they are aware of the info? This might cause difference between legacy projects and newly submitted scenario.

I did not reach out. I could easily check with the GCAM team, but I'm not really sure who to contact for the other teams. More generally, what should be the protocol when national modelers spot errors in their country that the global modelers may not be paying attention to.

d3y419 avatar Jan 27 '25 14:01 d3y419

@christophbertram could you review this correction for GCAM?

d3y419 avatar Jan 27 '25 14:01 d3y419

@dc-almeida could you review this correction for IMAGE?

d3y419 avatar Jan 27 '25 14:01 d3y419

@lbbaptista could you review this correction for COFFEE?

d3y419 avatar Jan 27 '25 14:01 d3y419

@dc-almeida could you review this correction for IMAGE?

probably better for @VassilisDaioglou :)

jkikstra avatar Jan 27 '25 15:01 jkikstra

@lbbaptista could you review this correction for COFFEE?

hey @d3y419, thanks for pointing it out!

@danielhuppmann can you please accept this correction for the COFFEE model?

lbbaptista avatar Jan 27 '25 18:01 lbbaptista