hyundai_kia_connect_api icon indicating copy to clipboard operation
hyundai_kia_connect_api copied to clipboard

refactor(Hyundai USA): Migration from climate actions methods to engine action methods

Open dbolger opened this issue 10 months ago • 0 comments

Continuation of https://github.com/Hyundai-Kia-Connect/hyundai_kia_connect_api/pull/404

There's still a lot to be done for other API implementations. This is purely focused on the BlueLink USA API for the time being.

It may be time to create a utils.py file to put the _determine_climate_options and other helper methods into.

Each API request seems to follow the same pattern:

  1. Determine variables (vehicle type, the action being taken, options)
  2. Generate the needed data/parameters to make a request using variables
  3. Send the request

With some more refactoring effort, the codebase could be simplified.

dbolger avatar Oct 29 '23 03:10 dbolger