hypothesis icon indicating copy to clipboard operation
hypothesis copied to clipboard

Published 20 hours ago • verified publisher icon HypothesisWorks

Adding type check and provide numpy strategy for NDArray

Open Cheukting opened this issue 3 years ago • 3 comments

An attempt to close #3150

This PR

  • [x] proved support in from_type for NDArrays in numpy.typing
  • [ ] provide a typing define of Shape to use when registering for numpy strategies (not sure is that what you mean @Zac-HD )

Feel free to let me know where I should put the tests, I put them in a separate file for my sanity but happy to move it.

Cheukting avatar Sep 06 '22 03:09 Cheukting

Thanks for the review. Will see if I got a chance to fix it today at the airport (this is an airport PR that I created at the airport)

Cheukting avatar Sep 07 '22 07:09 Cheukting

Updated the PR, will keep fixing it

Cheukting avatar Sep 09 '22 06:09 Cheukting

Cool! Will look at it when I have time next, thanks!

Cheukting avatar Sep 15 '22 22:09 Cheukting

Hi @Cheukting ! Thanks so much for your hard work on this PR. It turns out that there is a lot of hairy stuff going on here, so I opened #3491 to push forward with some of this work. Please feel free to check out some of my commits to see what changes I made from your work.

I hope to circle back to that PR in the not-so-distant future and will be happy to explain my thought process on it.

rsokl avatar Nov 17 '22 23:11 rsokl