Jayson Harshbarger
Jayson Harshbarger
That's basically what I want... regex search and multiple terms. I basically only need to add one line in `/web/pdf_find_controller.js` but once I do that I'm forced to "fork" `pdf_find_controller.js`,...
I'm thinking of this approach. Both would be changes to `stephanrauh/pdf.js` that would allow ngx-extended-pdf-viewer (or end users) to "plug" the find feature. 1. Update all methods in `/web/pdf_find_controller.js` (in...
That might work in some cases... but in my case I need to conditionally skip `#convertToRegExpString`. I'd either need a way to say use only `customQueryConversion` in some cases, skiping...
If we wanted that it would have to be something like: ``` customQueryConversion(query) { return false; // idempotent default implementation } #calculateMatch(pageIndex) { ... customQuery = customQueryConversion(query); if (customQuery !==...
I also might have some modifications to `#calculateRegExpMatch`. Obviously I'll do whatever you think is best for your maintance. I'd be happy if I can just do this. Notice that...
FYI.. overriding the find bar is working great. Adding the "matchRegex" buttons is not too difficult:
My override of `calculateMatch` is not right... but you get the idea. Edit: This is what I need: ```js const originalConvertToRegExpString = findController._convertToRegExpString.bind(findController); // only works if _convertToRegExpString is public...
@stephanrauh Let me know if the PR to pdfjs works for now. I tested locally and allowed me to override the `convertToRegExpString` method as shown. If that works, and once...
Do we also need to apply these changes to the non-bleeding edge version?
If you use the fat arrow I don't be able to access `this.state`... instead would need to use findController directly. Something like: ```js const originalConvertToRegExpString = findController._convertToRegExpString.bind(findController); // only works...