Scaffolding icon indicating copy to clipboard operation
Scaffolding copied to clipboard

Updating v0.2 to be working now

Open GoldenGamerLP opened this issue 3 years ago • 6 comments

Fixed major issues with codeql, legacylookup, and utf-8 encoding. Also added better gradle maintaining support.

GoldenGamerLP avatar Oct 30 '22 13:10 GoldenGamerLP

Thanks for your contribution, however I feel as if this would take less time if we implemented some of these changes when we're next available and close this pull request.

What are your thoughts?

joshuasing avatar Nov 08 '22 16:11 joshuasing

I'm currently working on those fixes. If you want, you can help me here, I would appreciate it if you would.

GoldenGamerLP avatar Nov 11 '22 08:11 GoldenGamerLP

+Push

GoldenGamerLP avatar Nov 28 '22 09:11 GoldenGamerLP

Could you please explain the bug this attempts to fix in LegacyLookup?

I can't see any major differences between your version and the original version except for the use of computeIfAbsent and Int2ObjectOpenHashMap.

joshuasing avatar Dec 06 '22 08:12 joshuasing

So this pull request has a major fix, the Legacy Json file can now be loaded. Im using Int2ObjectOpenHashMap because in my experience it was always much faster in such huge data models. The other thing is, it fixes for example the git workflow, which did not work. I see no problem why this pull request should no be merged other then the corrections that need to be done. The license headings of the classes must be taken over by someone else because I have problems with the encoding in intellij.

GoldenGamerLP avatar Jan 04 '23 12:01 GoldenGamerLP

  • The whole Project needs an update for version 1.16 and up. Schematics using MCEdit format are corrupted.

GoldenGamerLP avatar Jan 04 '23 12:01 GoldenGamerLP