hyperplay-desktop-client icon indicating copy to clipboard operation
hyperplay-desktop-client copied to clipboard

[Fix] Preserve symlinks during extraction

Open BrettCleary opened this issue 2 years ago • 4 comments

Recreates symlinks after a zip file is extracted

Testing

Test with synergy of serra native mac build latest main release

  • Synergy of Serra Genesis.app/Contents/Frameworks/Electron Framework.framework/* are all simlinks. You can verify with ls -l which will return lrwxrwxrwx in the first column. l is for "link"

Use the following Checklist if you have changed something on the Backend or Frontend:

  • [ ] Tested the feature and it's working on a current and clean install.
  • [ ] Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • [ ] Created / Updated Tests (If necessary)
  • [ ] Created / Updated documentation (If necessary)

BrettCleary avatar Sep 18 '23 22:09 BrettCleary

Seems I'll need to apply these as soon as merged to my extraction PR, since that method no longer exists and we got a class instead ExtractZipService

red-game-dev avatar Nov 06 '23 18:11 red-game-dev

This is also occurring on MCVERSE with their MAC build (which is now disabled due to this issue). https://hyperplay-workspace.slack.com/archives/C05RXC4S03A/p1704740561418779

Ticket for MCVERSE issue https://github.com/HyperPlay-Gaming/hyperplay-desktop-client/issues/691

nyghtstalker avatar Jan 09 '24 17:01 nyghtstalker

next attempt: use the native system unzip tool

awantoch avatar Jan 09 '24 22:01 awantoch

Will do more testing on this other PR #702

flavioislima avatar Jan 12 '24 16:01 flavioislima