express-tdd icon indicating copy to clipboard operation
express-tdd copied to clipboard

refactor: replaced toHaveBeenCalledWith with toBeCalledWith

Open MitchelSt opened this issue 5 years ago • 1 comments

According to the Jest's docs toHaveBeenCalledWith goes under the alias toBeCalledWith: https://jestjs.io/docs/en/expect#tohavebeencalledwitharg1-arg2-.

This might be the best approach for clarification and consistency.

MitchelSt avatar Oct 15 '20 23:10 MitchelSt

Hey thanks for the PR @MitchelSt ! Unfortunately I think it would not be consistent for the students if I use toHaveBeenCalledWith in the videos and they see toBeCalledWith in the code. Although I might be using the other one in future to save a few keystrokes :)!

Hyllesen avatar Oct 16 '20 10:10 Hyllesen