fix: Update `lockscreen.sh` path in .config/hypr/keybindings.conf
Pull Request
Description
Please read these instructions and remove unnecessary text.
- Try to include a summary of the changes and which issue is fixed.
- Also include relevant motivation and context (if applicable).
- Make sure to make PR against dev and not the master
- List any dependencies that are required for this change. (e.g., packages or other PRs)
- Provide a link if there is an issue related to this pull request. e.g., Fixes # (issue)
- Please add Reviewers, Assignees, Labels, Projects, and Milestones to the PR. (if applicable)
Type of change
Please put an x in the boxes that apply:
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation update (non-breaking change; modified files are limited to the documentations)
- [ ] Technical debt (a code change that does not fix a bug or add a feature but makes something clearer for devs)
- [ ] Other (provide details below)
Checklist
Please put an x in the boxes that apply:
- [x] I have read the CONTRIBUTING document.
- [x] My code follows the code style of this project.
- [x] My commit message follows the commit guidelines.
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [ ] I have added a changelog entry.
- [ ] I have added necessary comments/documentation to my code.
- [ ] I have added tests to cover my changes.
- [x] I have tested my code locally and it works as expected.
- [ ] All new and existing tests passed.
Screenshots
(if appropriate)
Additional context
Add any other context about the problem here.
In the .config/hypr/keybindings.conf file, the binding for executing the lockscreen.sh script is missing $srcPath/ at the beginning, making this binding not work out of the box.
⚠️ Warning: PR targeting master branch detected!
This PR is targeting master but should target dev instead.
According to our Quarterly Release Policy:
-
All pull requests must be submitted to the
devbranch - Changes go through
devfirst for testing before being merged tomasterduring quarterly release windows (1st & 3rd Fridays) -
PRs to
masterare only allowed for emergencies
Required Action:
-
Change the base branch from
mastertodev - Follow the pull request template
If this is an emergency fix, please add a comment explaining why it needs to target master directly.
This is an automated message enforcing our quarterly release workflow.
It should work though unless users change the $PATH or not using uwsm.
also can you use this command instead: hyde-shell lock-session.
It should work though unless users change the $PATH or not using uwsm.
also can you use this command instead:
hyde-shell lock-session.
Oh ok that makes sense! So by that logic, should every other bind using HyDE scripts use hyde-shell instead of $srcPath?
Yes! can you edit the pr and convert them all. But can you also check for any regressions??? Thank you!
Done! I will be checking for any regressions shortly! Should I do so in the hydevm? Or would just manually testing the keybinds on my local machine be fine?
doing it in a vm will be the best option. Just take your time.