[UWSM] Start processes as service instead of scope by default
Pull Request
Description
Change default process startup to service as it is recommended in the official systemd docs and also followed by kde plasma(see screenshot for proof).
Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation update (non-breaking change; modified files are limited to the documentations)
- [ ] Technical debt (a code change that does not fix a bug or add a feature but makes something clearer for devs)
- [x] Other (provide details below)
Checklist
- [x] I have read the CONTRIBUTING document.
- [x] My code follows the code style of this project.
- [x] My commit message follows the commit guidelines.
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [ ] I have added a changelog entry.
- [ ] I have added necessary comments/documentation to my code.
- [ ] I have added tests to cover my changes.
- [x] I have tested my code locally and it works as expected.
- [ ] All new and existing tests passed.
Screenshots
Thanks!
But I want to note that all waybar modules are using scope. this way if waybar dies all child process are cleaned.
Even though I explicitly use scope, maybe I forgot something so can you also check the modules please? π₯Ίπ
I tested it , no problems as expected since the modules are manage by waybar itself and systemd waits for waybar to cleanly terminate(point of a service, that's why it is recommended)
hmmm before merging this I need to test first.
it breaks one module in hyde (breaks more of my local modules)
an example for this is
as you see, we are now required to use -t scope if we intend to capture the stdout like a waybar module. Gladly it did break single module.
in lockscreen script (invokes a lockscreen) https://github.com/HyDE-Project/HyDE/blob/401ccca0a4d581d52f618e296d298b23f304a822/Configs/.local/lib/hyde/lockscreen.sh#L19 this breaks as even if we use *.scope in the unit name -t scope is required. as it contradicts the APP2UNIT_TYPE="service" This should be updated to .service
I am not saying that this PR is bad but we need to adjust some of our script first. Can you help me find some stuff that breaks. Right now I only seen those 2 mentioned.
I needed help in deciding that should all the apps executed by the launcher use service?
@kRHYME7 After more testing, it also breaks hyprlock which is a one line fix, and since app2unit is used at multiple places there could be more things to break. I think the best way is to just launch apps through rofi as service. The env should have been there since the uwsm merge, but anyway.
I won't be releasing until 25.11.1 so We have extra time to fix those.
As of the moment I only stumbled upon those 2 regressions.
The env should have been there since the uwsm merge, but anyway.
Yeah I should have known. I just use the defaults as provided by uwsm.