react-native-lottie-splash-screen icon indicating copy to clipboard operation
react-native-lottie-splash-screen copied to clipboard

123

Open xieyanghui opened this issue 8 months ago • 2 comments

Summary by CodeRabbit

  • New Features

    • Enhanced the Android splash screen with an option for full-screen display, allowing better adaptation for devices with display cutouts and smoother animation handling.
  • Chores

    • Upgraded the package version to 1.1.2 and removed outdated example, configuration, and documentation files to streamline the project.

xieyanghui avatar Mar 23 '25 02:03 xieyanghui

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Mar 23 '25 02:03 google-cla[bot]

Walkthrough

This pull request primarily removes many configuration, documentation, build, and example files—including various ignore files, project-specific configurations for Android and iOS, and testing templates—to streamline the repository. The most significant functional change is in the Android splash screen implementation, where the SplashScreen class has been updated to support a full-screen mode through an additional parameter and a new method. Additionally, the root package.json has been bumped to version 1.1.2 with added mappings for stream and cryptographic modules tailored for React Native.

Changes

File(s) Change Summary
.gitignore, .npmignore, CONTRIBUTING.md, add-LaunchScreen-tutorial-for-ios.md Deleted root configuration, ignore, and contribution guideline files.
android/.npmignore, android/proguard-rules.pro Removed Android-specific npm ignore rules and ProGuard configuration files.
android/src/main/java/org/devio/rn/splashscreen/SplashScreen.java Updated splash screen functions: added a fullScreen parameter to show, introduced setActivityAndroidP for full-screen support, and refined dialog dismissal logic.
examples/... Removed an extensive set of examples, configuration, build, test, and asset files (including Buck, Gradle, Xcode project settings, ESLint, Flow, and others).
issue_template.md Deleted the issue report template file.
package.json Updated version from 1.1.1 to 1.1.2 and added new mappings for React Native modules handling streams and cryptographic functions.

Sequence Diagram(s)

sequenceDiagram
    participant A as Activity
    participant S as SplashScreen
    participant D as Dialog
    A->>S: show(activity, themeResId, lottieId, fullScreen)
    alt fullScreen true
        S->>S: setActivityAndroidP(dialog)
    end
    S->>D: Display splash screen
    D-->>S: Animation finished? (isAnimationFinished)
    S->>A: Dismiss splash dialog

Poem

Hopping through the code I roam,
Seeing files bid a fond goodbye,
Old configs and tests no longer foam,
Now a full-screen splash lights the sky.
With version bump and mappings anew,
I nibble on changes—oh so true! 🐇

✨ Finishing Touches
  • [ ] 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Mar 23 '25 02:03 coderabbitai[bot]