Humanizer icon indicating copy to clipboard operation
Humanizer copied to clipboard

fixes #348

Open davidceto1 opened this issue 7 years ago • 2 comments

Here is a checklist you should tick through before submitting a pull request:

  • [ ] Implementation is clean
  • [ ] Code adheres to the existing coding standards; e.g. no curlies for one-line blocks, no redundant empty lines between methods or code blocks, spaces rather than tabs, etc.
  • [ ] No ReSharper warnings
  • [ ] There is proper unit test coverage
  • [ ] If the code is copied from StackOverflow (or a blog or OSS) full disclosure is included. That includes required license files and/or file headers explaining where the code came from with proper attribution
  • [ ] There are very few or no comments (because comments shouldn't be needed if you write clean code)
  • [ ] Xml documentation is added/updated for the addition/change
  • [ ] Your PR is (re)based on top of the latest commits from the dev branch (more info below)
  • [ ] Link to the issue(s) you're fixing from your PR description. Use fixes #<the issue number>
  • [ ] Readme is updated if you change an existing feature or add a new one
  • [ ] Run either build.cmd or build.ps1 and ensure there are no test failures

davidceto1 avatar Aug 15 '18 16:08 davidceto1

CLA assistant check
All CLA requirements met.

dnfclas avatar Aug 15 '18 16:08 dnfclas

As discussed in the original issue, how would this handle a case like thirtieth or seventeenth?

clairernovotny avatar Aug 16 '18 21:08 clairernovotny

@davidceto1

given the lack of way to handle "As discussed in the original issue, how would this handle a case like thirtieth or seventeenth?", i will close this one for now. please re-submit if you find a way to handle it

SimonCropp avatar Feb 16 '24 05:02 SimonCropp