Humanizer icon indicating copy to clipboard operation
Humanizer copied to clipboard

Ukrainian dev

Open Palindromer opened this issue 8 years ago • 2 comments

Here is a checklist you should tick through before submitting a pull request:

  • [ ] Implementation is clean
  • [ ] Code adheres to the existing coding standards; e.g. no curlies for one-line blocks, no redundant empty lines between methods or code blocks, spaces rather than tabs, etc.
  • [ ] No ReSharper warnings
  • [ ] There is proper unit test coverage
  • [ ] If the code is copied from StackOverflow (or a blog or OSS) full disclosure is included. That includes required license files and/or file headers explaining where the code came from with proper attribution
  • [ ] There are very few or no comments (because comments shouldn't be needed if you write clean code)
  • [ ] Xml documentation is added/updated for the addition/change
  • [ ] Your PR is (re)based on top of the latest commits from the dev branch (more info below)
  • [ ] Link to the issue(s) you're fixing from your PR description. Use fixes #<the issue number>
  • [ ] Readme is updated if you change an existing feature or add a new one
  • [ ] Run either build.cmd or build.ps1 and ensure there are no test failures

Palindromer avatar Dec 20 '17 15:12 Palindromer

You have a conflict. Rebase with the latest and push. Please let me know when done and I will review. Thanks.

MehdiK avatar Dec 23 '17 06:12 MehdiK

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

:x: Palindromer sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

dnfclas avatar May 03 '18 19:05 dnfclas