Humanizer icon indicating copy to clipboard operation
Humanizer copied to clipboard

added German TimeOnlyToClockNotation

Open SpocWeb opened this issue 2 years ago • 4 comments

Here is a checklist you should tick through before submitting a pull request:

  • [x] Implementation is clean
  • [x] Code adheres to the existing coding standards; e.g. no curlies for one-line blocks, no redundant empty lines between methods or code blocks, spaces rather than tabs, etc.
  • [x] No Code Analysis warnings
  • [x] There is proper unit test coverage
  • [x] If the code is copied from StackOverflow (or a blog or OSS) full disclosure is included. That includes required license files and/or file headers explaining where the code came from with proper attribution
  • [x] There are very few or no comments (because comments shouldn't be needed if you write clean code)
  • [x] Xml documentation is added/updated for the addition/change
  • [x] Your PR is (re)based on top of the latest commits from the main branch (more info below)
  • [x] Link to the issue(s) you're fixing from your PR description. Use fixes #<the issue number>
  • [x] Readme is updated if you change an existing feature or add a new one
  • [x] Run either build.cmd or build.ps1 and ensure there are no test failures

SpocWeb avatar Dec 27 '22 12:12 SpocWeb

@hangy you can add a culture like "de-DE-BY" with "dreiviertel zwölf" if you like 😜

SpocWeb avatar Dec 28 '22 13:12 SpocWeb

@SpocWeb can you rebase

SimonCropp avatar Feb 16 '24 05:02 SimonCropp

@SimonCropp sure, will try and also add some explanation to the contended Method(s) over the weekend, thanks for considering this.

SpocWeb avatar Feb 16 '24 06:02 SpocWeb

Hi, I don't know why the CI Builds fail. I am not allowed to look at the errors and locally it builds for me in all Configurations. Please share the Build Error Details with me.

SpocWeb avatar Feb 24 '24 18:02 SpocWeb