Humanizer icon indicating copy to clipboard operation
Humanizer copied to clipboard

Published 20 hours ago • verified publisher icon Humanizr

`DateOnly` has current date return 'today'

Open behroozbc opened this issue 2 years ago • 4 comments

When you want to humanize the DateOnly that has current date return 'now'.it's better to return 'today'. 'now' Word referee current date and time but 'today' referee only current date

behroozbc avatar Mar 05 '22 11:03 behroozbc

I agree. Just for completeness:

https://github.com/Humanizr/Humanizer/blob/937e827b8d664ce800b31160e51e8b2eca95fadc/src/Humanizer.Tests.Shared/DateOnlyHumanizeTests.cs#L36

Should this also be "one month from today" instead? The precision is the same as "now" vs. "today".

hangy avatar Mar 07 '22 18:03 hangy

I'm new to contributing to this repository. I found DateOnly behind the scenes using the DateTime algorithm.https://github.com/Humanizr/Humanizer/blob/937e827b8d664ce800b31160e51e8b2eca95fadc/src/Humanizer/DateTimeHumanizeStrategy/DateTimeHumanizeAlgorithms.cs#L165 It seems to me DateOnly needs its algorithm.

behroozbc avatar Mar 07 '22 23:03 behroozbc

Is anyone already looking into this? If not, I'd be willing to have a go at it.

louis-z avatar Mar 20 '22 21:03 louis-z

Is anyone already looking into this? If not, I'd be willing to have a go at it.

Can I help you? I want to learn and know what happened inside of Humanizer.

behroozbc avatar Mar 20 '22 21:03 behroozbc

Is anyone already looking into this? Can I try to fix it? Please assign issue

hemalshah28 avatar Nov 01 '22 21:11 hemalshah28

Is anyone already looking into this? Can I try to fix it? Please assign issue

I looked at the issue briefly back in March... but my branch has become stale since then. As far as I'm concerned, you can go ahead. 😉

louis-z avatar Nov 01 '22 21:11 louis-z

Hello, is this fixed or still open?

michaela559 avatar Nov 21 '22 17:11 michaela559

Hello, is this fixed or still open?

I think you can start and implement a new pull request. In addition, you can use this pull request experience.

behroozbc avatar Nov 21 '22 18:11 behroozbc

My first time contributing to a github project, let me know if there is anything else I should do.

AJacksonCT avatar Apr 25 '23 19:04 AJacksonCT

Finally completed a PR that passed. Hopefully, this is acceptable and can be merged

AJacksonCT avatar Jun 14 '23 14:06 AJacksonCT

@ AJacksonCT if you still want this approach, can you re submit as an opt in approach

SimonCropp avatar Feb 16 '24 12:02 SimonCropp