label-studio icon indicating copy to clipboard operation
label-studio copied to clipboard

feat: DIA-2062: Batch writes for cloud storage import

Open hakan458 opened this issue 7 months ago • 7 comments

Changes how cloud storage import works so that we are bulk_create-ing Tasks, Annotations, and Predictions Before we were calling add_task for every single new key (path) from cloud storage. Now we will create tasks in batches (setting controlled to 50 currently)

hakan458 avatar Apr 15 '25 03:04 hakan458

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: label_studio/io_storages/base_models.py

Function Unhandled Issue
_scan_and_create_links ValueError: Error loading JSON from file "label1.json". io_storages.base_models.import_sync_bac...
Event Count: 3
_scan_and_create_links ValueError: Storage status (in_progress) must be QUEUED to move it IN_PROGRESS io_storages.base...
Event Count: 2
_scan_and_create_links ValueError: Error on key kac_v6_collabo/annotation.json: For S3 your JSON file must be a dictionary with one task ...
Event Count: 1
_scan_and_create_links ValueError: Error loading JSON from file "wafer_aoi_defects_batch1/Field Failure/N_PBI_ZN030_4964150_13.093.png". ...
Event Count: 1
_scan_and_create_links ValueError: If you use "predictions" field in the task, you must put "data" field in the task too ...
Event Count: 1

Did you find this useful? React with a 👍 or 👎

sentry[bot] avatar Apr 15 '25 03:04 sentry[bot]

Deploy Preview for label-studio-storybook ready!

Name Link
Latest commit 11c02115bf903d850a5fa31efbb7c293910add6f
Latest deploy log https://app.netlify.com/sites/label-studio-storybook/deploys/6802906daa0be60008cdb098
Deploy Preview https://deploy-preview-7372--label-studio-storybook.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Apr 15 '25 03:04 netlify[bot]

Deploy Preview for label-studio-docs-new-theme ready!

Name Link
Latest commit 11c02115bf903d850a5fa31efbb7c293910add6f
Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/6802906d2e0d8300086eb7b9
Deploy Preview https://deploy-preview-7372--label-studio-docs-new-theme.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Apr 15 '25 03:04 netlify[bot]

Deploy Preview for heartex-docs ready!

Name Link
Latest commit 11c02115bf903d850a5fa31efbb7c293910add6f
Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/6802906d10d3f80008cd3782
Deploy Preview https://deploy-preview-7372--heartex-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Apr 15 '25 03:04 netlify[bot]

Codecov Report

Attention: Patch coverage is 66.12903% with 21 lines in your changes missing coverage. Please review.

Project coverage is 77.22%. Comparing base (849c3df) to head (11c0211). Report is 330 commits behind head on develop.

Files with missing lines Patch % Lines
label_studio/io_storages/base_models.py 65.57% 21 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7372      +/-   ##
===========================================
- Coverage    77.27%   77.22%   -0.06%     
===========================================
  Files          190      190              
  Lines        14697    14721      +24     
===========================================
+ Hits         11357    11368      +11     
- Misses        3340     3353      +13     
Flag Coverage Δ
pytests 77.22% <66.12%> (-0.06%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Apr 16 '25 21:04 codecov[bot]

/fm sync

Workflow run

hakan458 avatar Apr 18 '25 17:04 hakan458

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

robot-ci-heartex avatar Jun 07 '25 02:06 robot-ci-heartex

This PR was closed because it has been stalled for 10 days with no activity.

robot-ci-heartex avatar Jun 17 '25 02:06 robot-ci-heartex