label-studio icon indicating copy to clipboard operation
label-studio copied to clipboard

fix: LEAP-1494: Padding in new textarea is missing in LSO

Open ricardoantoniocm opened this issue 1 year ago • 3 comments

Ensures padding and border-radius is correct for added textarea regions and corresponding textarea fields

PR fulfills these requirements

  • [X] Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • [ ] Tests for the changes have been added/updated (for bug fixes/features)
  • [ ] Docs have been added/updated (for bug fixes/features)
  • [ ] Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • [X] Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • [X] Product design
  • [ ] Backend (Database)
  • [ ] Backend (API)
  • [X] Frontend

What does this fix?

Padding and border radius missing for Textarea component and its results container.

What is the new behavior?

Textarea and results containers now have expected padding and border radius. CSS variables used now have corresponding fallbacks.

Screenshots:

Previous look: image image

Improved look: image

image

Which logical domain(s) does this change affect?

(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.) Label Stream, Review Stream and Labeling Configuration

ricardoantoniocm avatar Oct 09 '24 20:10 ricardoantoniocm

Deploy Preview for heartex-docs canceled.

Name Link
Latest commit 5fe7b2d872642817c2206273e032d526e3b68c58
Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/67095f91187c4b0009ed247e

netlify[bot] avatar Oct 09 '24 20:10 netlify[bot]

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
Latest commit 5fe7b2d872642817c2206273e032d526e3b68c58
Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/67095f911ffd410008407a17

netlify[bot] avatar Oct 09 '24 20:10 netlify[bot]

/git merge

Workflow run Successfully merged: 37 files changed, 282 insertions(+), 88 deletions(-)

ricardoantoniocm avatar Oct 09 '24 20:10 ricardoantoniocm