label-studio icon indicating copy to clipboard operation
label-studio copied to clipboard

feat: Issue-5094: Auto set SESSION_COOKIE_PATH if LABEL_STUDIO_HOST is set

Open kebe7jun opened this issue 1 year ago • 2 comments

Fix https://github.com/HumanSignal/label-studio/issues/5094

PR fulfills these requirements

  • [x] Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • [ ] Tests for the changes have been added/updated (for bug fixes/features)
  • [ ] Docs have been added/updated (for bug fixes/features)
  • [ ] Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • [x] Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • [ ] Product design
  • [ ] Backend (Database)
  • [x] Backend (API)
  • [ ] Frontend

Describe the reason for change

(link to issue, supportive screenshots etc.)

As the Issue description says, we hope to deploy multiple Label Studio instances under the same Host

What does this fix?

(if this is a bug fix)

Django will read the value of SESSION_COOKIE_PATH to set it to PATH, so we only need to set this value

What is the new behavior?

(if this is a breaking or feature change)

After setting LABEL_STUDIO_HOST, the sessionid cookie will be saved to the subpath instead of '/'

What is the current behavior?

(if this is a breaking or feature change)

sessionid cookie's path always be '/'.

What libraries were added/updated?

(list all with version changes)

N/A

Does this change affect performance?

(if so describe the impacts positive or negative) N/A

Does this change affect security?

(if so describe the impacts positive or negative)

N/A

What alternative approaches were there?

(briefly list any if applicable)

N/A

What feature flags were used to cover this change?

(briefly list any if applicable)

N/A

Does this PR introduce a breaking change?

(check only one)

  • [ ] Yes, and covered entirely by feature flag(s)
  • [ ] Yes, and covered partially by feature flag(s)
  • [X] No
  • [ ] Not sure (briefly explain the situation below)

What level of testing was included in the change?

(check all that apply)

  • [ ] e2e
  • [ ] integration
  • [ ] unit

Which logical domain(s) does this change affect?

(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)

Authentication

kebe7jun avatar Sep 26 '24 02:09 kebe7jun

Deploy request for heartex-docs pending review.

Visit the deploys page to approve it

Name Link
Latest commit 301cfde59e3b9df236ff66b6d9fcc7b7cf7a6ca6

netlify[bot] avatar Sep 26 '24 02:09 netlify[bot]

Deploy request for label-studio-docs-new-theme pending review.

Visit the deploys page to approve it

Name Link
Latest commit 301cfde59e3b9df236ff66b6d9fcc7b7cf7a6ca6

netlify[bot] avatar Sep 26 '24 02:09 netlify[bot]

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

robot-ci-heartex avatar Nov 11 '24 01:11 robot-ci-heartex

This PR was closed because it has been stalled for 10 days with no activity.

robot-ci-heartex avatar Nov 21 '24 02:11 robot-ci-heartex