feat: add region:visibility-all shortcut (ctrl+h)
PR fulfills these requirements
- [X] Commit message(s) and PR title follows the format
[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change madeex.fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors - [ ] Tests for the changes have been added/updated (for bug fixes/features)
- [ ] Docs have been added/updated (for bug fixes/features)
- [X] Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
- [X] Self-reviewed and ran all changes on a local instance (for bug fixes/features)
Change has impacts in these area(s)
(check all that apply)
- [ ] Product design
- [ ] Backend (Database)
- [ ] Backend (API)
- [X] Frontend
Describe the reason for change
(link to issue, supportive screenshots etc.) No shortcut existed to hide all regions. It had to be done through a click tot he dedicated button on the sidebar
What does this fix?
(if this is a bug fix)
What is the new behavior?
(if this is a breaking or feature change) by default, ctrl+h now hide all regions if one is visible. If none is visible, it show all regions.
What is the current behavior?
(if this is a breaking or feature change) ctrl + h has no behavior on label studio.
What libraries were added/updated?
(list all with version changes) None
Does this change affect performance?
(if so describe the impacts positive or negative) No
Does this change affect security?
(if so describe the impacts positive or negative) No
What alternative approaches were there?
(briefly list any if applicable) Click on the sidebar button
What feature flags were used to cover this change?
(briefly list any if applicable) None
Does this PR introduce a breaking change?
(check only one)
- [ ] Yes, and covered entirely by feature flag(s)
- [ ] Yes, and covered partially by feature flag(s)
- [X] No
- [ ] Not sure (briefly explain the situation below)
What level of testing was included in the change?
(check all that apply)
- [ ] e2e
- [ ] integration
- [ ] unit Does manual testing counts for a shortcut (I kind of hate myself for asking)?
Which logical domain(s) does this change affect?
(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)
Deploy request for label-studio-docs-new-theme pending review.
Visit the deploys page to approve it
| Name | Link |
|---|---|
| Latest commit | 9c950a2063cef73218a6ce13d0ccfe47ae76cf13 |
Deploy request for heartex-docs pending review.
Visit the deploys page to approve it
| Name | Link |
|---|---|
| Latest commit | 9c950a2063cef73218a6ce13d0ccfe47ae76cf13 |
I reverted my changes made to web/dist, no idea if that's what's expected
Hello! Would it be possible to review this PR? I tried to make it as small and as little as possible to ease review. Thanks!
Up! @hlomzik maybe?
Up! I'm trying with @yyassi-heartex this time
Oh, thank you for patience and for this contribution, @LouisJULIEN ! It's very straightforward and precise improvement, we'll run it through our process and will merge soon!
Hey @hlomzik , thanks for running the CI. Is everything good?
up @hlomzik