label-studio
label-studio copied to clipboard
feat: 5495: Add a note to a relation
PR fulfills these requirements
- [x] Commit message(s) and PR title follows the format
[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change madeex.fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors - [x] Tests for the changes have been added/updated (for bug fixes/features)
- [ ] Docs have been added/updated (for bug fixes/features)
- [ ] Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
- [x] Self-reviewed and ran all changes on a local instance (for bug fixes/features)
Change has impacts in these area(s)
(check all that apply)
- [ ] Product design
- [ ] Backend (Database)
- [ ] Backend (API)
- [x] Frontend
Describe the reason for change
https://github.com/HumanSignal/label-studio/issues/5495
What does this fix?
What is the new behavior?
Users can add a note to each relation.
What is the current behavior?
Users can't add a note to each relation.
What libraries were added/updated?
DOMPurify
Does this change affect performance?
Now users can avoid confusion in the relations by adding notes.
Does this change affect security?
DOMPurify avoid malicious code in the TextArea
What alternative approaches were there?
What feature flags were used to cover this change?
Does this PR introduce a breaking change?
(check only one)
- [ ] Yes, and covered entirely by feature flag(s)
- [ ] Yes, and covered partially by feature flag(s)
- [x] No
- [ ] Not sure (briefly explain the situation below)
What level of testing was included in the change?
(check all that apply)
- [x] e2e
- [x] integration
- [ ] unit
Which logical domain(s) does this change affect?
Relations
Deploy request for label-studio-docs-new-theme pending review.
Visit the deploys page to approve it
| Name | Link |
|---|---|
| Latest commit | 6833a90f2c85ed14282211cfc0e428507164315d |
Deploy request for heartex-docs pending review.
Visit the deploys page to approve it
| Name | Link |
|---|---|
| Latest commit | 6833a90f2c85ed14282211cfc0e428507164315d |
Hi @Car85, if you want to be eligible for the bounty of $50 you'll need to apply to the issue here: https://gitpay.me/#/task/757
Hi @Car85, if you want to be eligible for the bounty of $50 you'll need to apply to the issue here: https://gitpay.me/#/task/757
Hi @robinclaes , it seems that some steps are not included. Once they are completed, I will send the solution.
I'm on the tests right now, will get to the PR soon.
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.