label-studio icon indicating copy to clipboard operation
label-studio copied to clipboard

feat: feature/Labels subgroups

Open FrsECM opened this issue 1 year ago • 2 comments

PR fulfills these requirements

  • [ x] Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • [ ] Tests for the changes have been added/updated (for bug fixes/features)
  • [ ] Docs have been added/updated (for bug fixes/features)
  • [ ] Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • [x] Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • [ ] Product design
  • [ ] Backend (Database)
  • [ ] Backend (API)
  • [x] Frontend

Describe the reason for change

Often, we need more than one class when we annotate image. There can also be some group of labels that have a meaning.

For example, let's take the example of the plane image : image

The plane can be white/red, Boeing/Airbus. It can have only one color and only one manufacturer.

What does this fix?

With this fix, we are able to group labels in subgroups. In this case, we will group labels in combo-boxes. image

What is the new behavior?

The UI will automatically group labels in subgroup. If we activate mode "multiple" :

  • It will allow multiple labels in the main group (without subgroup)
  • It will allow only one label per subgroup If we activate mode "subgroup":
  • it will allow only one label in the main group
  • It will allow only one label per subgroup

https://github.com/HumanSignal/label-studio/assets/26071804/b04d6259-a259-418d-b7f3-8f9b8ff20f56

What is the current behavior?

It will unpack all options and it will be complicate to identify main and subgroups.

What libraries were added/updated?

None

Does this change affect performance?

No

Does this change affect security?

No

What alternative approaches were there?

It would have been possible to create a complex taxonomy but it's much more impactful.

What feature flags were used to cover this change?

???

Does this PR introduce a breaking change?

(check only one)

  • [ ] Yes, and covered entirely by feature flag(s)
  • [ ] Yes, and covered partially by feature flag(s)
  • [ ] No
  • [x ] Not sure (briefly explain the situation below)

For me it's not a major change because the old behavior is not impacted.

What level of testing was included in the change?

(check all that apply)

  • [ ] e2e
  • [ ] integration
  • [ ] unit

Which logical domain(s) does this change affect?

It will allow to annotate more precisely when we have "nested" classes on an object.

FrsECM avatar Apr 23 '24 09:04 FrsECM

Deploy request for label-studio-docs-new-theme pending review.

Visit the deploys page to approve it

Name Link
Latest commit 5062abec8377afa6736dee7164fbe1cde0b64208

netlify[bot] avatar Apr 23 '24 09:04 netlify[bot]

Deploy request for heartex-docs pending review.

Visit the deploys page to approve it

Name Link
Latest commit 5062abec8377afa6736dee7164fbe1cde0b64208

netlify[bot] avatar Apr 23 '24 09:04 netlify[bot]

/jira create

Workflow run Jira issue TRIAG-576 is created

sajarin avatar May 29 '24 16:05 sajarin

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

robot-ci-heartex avatar Jul 21 '24 01:07 robot-ci-heartex

This PR was closed because it has been stalled for 10 days with no activity.

robot-ci-heartex avatar Aug 01 '24 01:08 robot-ci-heartex

Can you have a look on this one ? Thanks.

FrsECM avatar Aug 01 '24 05:08 FrsECM

@sajarin Did you have time to have a look on this one ? It was marked done due to non activity.

I currently use a labelstudio version with this feature but i have to maintain it in a fork what is not efficient. Thanks !

FrsECM avatar Sep 03 '24 06:09 FrsECM