label-studio icon indicating copy to clipboard operation
label-studio copied to clipboard

fix: get_predictions for tasks in projects without an ML backend

Open fvdnabee opened this issue 2 years ago • 5 comments

PR fulfills these requirements

  • [ ] Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • [ ] Tests for the changes have been added/updated (for bug fixes/features)
  • [ ] Docs have been added/updated (for bug fixes/features)
  • [ ] Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • [x] Self-reviewed and ran all changes on a local instance (for bug fixes/features)

I don't have a TICKET-ID I'm afraid.

Change has impacts in these area(s)

(check all that apply)

  • [ ] Product design
  • [ ] Backend (Database)
  • [x] Backend (API)
  • [ ] Frontend

Describe the reason for change

(link to issue, supportive screenshots etc.) Predictions aren't retrieved for tasks in projects without an ML backend. Tasks with (offline) pre-annotations have predictions without an ML backend. For these tasks annotators do not see the prediction suggestion when labeling.

Versions > 1.8.2post0 are impacted, bug fix should likely be back ported to 1.8.x. Users on impacted versions can revert to the old behavior by disabling the ff_front_dev_1682_model_version_dropdown_070622_short feature flag. Related PR that introduced this change: https://github.com/HumanSignal/label-studio/pull/4363

What does this fix?

(if this is a bug fix) Missing task predictions for projects without an ML backend.

What is the new behavior?

(if this is a breaking or feature change) When there are no model versions from an ML backend, then try the model version set in the project settings.

What is the current behavior?

(if this is a breaking or feature change) Project model versions are ignored.

What libraries were added/updated?

(list all with version changes)

Does this change affect performance?

(if so describe the impacts positive or negative)

Does this change affect security?

(if so describe the impacts positive or negative)

What alternative approaches were there?

(briefly list any if applicable)

What feature flags were used to cover this change?

(briefly list any if applicable)

Does this PR introduce a breaking change?

(check only one)

  • [ ] Yes, and covered entirely by feature flag(s)
  • [ ] Yes, and covered partially by feature flag(s)
  • [x] No
  • [ ] Not sure (briefly explain the situation below)

What level of testing was included in the change?

(check all that apply)

  • [x] e2e
  • [ ] integration
  • [ ] unit

Which logical domain(s) does this change affect?

(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)

Backend tasks api.

fvdnabee avatar Oct 19 '23 16:10 fvdnabee

Deploy request for heartex-docs pending review.

Visit the deploys page to approve it

Name Link
Latest commit ce33b97672bfd644ccf3070c33e9f4ca514b9662

netlify[bot] avatar Oct 19 '23 16:10 netlify[bot]

Deploy request for label-studio-docs-new-theme pending review.

Visit the deploys page to approve it

Name Link
Latest commit ce33b97672bfd644ccf3070c33e9f4ca514b9662

netlify[bot] avatar Oct 19 '23 16:10 netlify[bot]

Any chance this could get triaged/reviewed? CC @makseq

fvdnabee avatar Oct 24 '23 12:10 fvdnabee

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

robot-ci-heartex avatar Jun 10 '24 21:06 robot-ci-heartex

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

robot-ci-heartex avatar Oct 19 '24 01:10 robot-ci-heartex

This PR was closed because it has been stalled for 10 days with no activity.

robot-ci-heartex avatar Oct 29 '24 02:10 robot-ci-heartex