WebApp icon indicating copy to clipboard operation
WebApp copied to clipboard

[WIP] Feature about me

Open brickmaker17 opened this issue 5 years ago • 3 comments

There is still a lot of work that needs to be done but I thought this would be the easiest way for people to see progress and make comments on the code.

brickmaker17 avatar Oct 26 '18 05:10 brickmaker17

Thanks

Lulalaby avatar Oct 26 '18 05:10 Lulalaby

Thanks for you contribution @brickmaker17 ! I would suggest to make a component out of it to keep the page component cleaner.

appinteractive avatar Oct 26 '18 08:10 appinteractive

@brickmaker17 thank you so much for your contribution! I haven't run the code on my machine yet. But as @appinteractive suggested, I would prefer to have a separate component for it.

But most importantly: Please write tests! The fact that we did not write software tests in the past is an inexcusable flaw. You can ~find inspiration~ copy&paste from the few existing tests here or some not yet merged component tests here. It's easy, fun and makes your code cleaner and your components modular and reusable with minimal dependencies.

Here are some resources: https://vue-test-utils.vuejs.org/guides/

roschaefer avatar Oct 26 '18 13:10 roschaefer