Curtail icon indicating copy to clipboard operation
Curtail copied to clipboard

Indicate file compression was skipped

Open ARAKHN1D opened this issue 1 year ago • 2 comments

Adds a visual indication that file compression was skipped, along with a button explaining why.

The skipping mechanism was also improved so it actually skips files in overwrite mode rather than just reverting them.

indicator

Supersedes #249 because I did something weird with Git on accident :D Closes #245

ARAKHN1D avatar Oct 13 '24 15:10 ARAKHN1D

The look is perfect for me! Will try to test your pr soon to understand all and validate changes :) Good job as always!

Huluti avatar Oct 15 '24 08:10 Huluti

Also, please add you in the contributors of the app in the About window, you deserve it!

Huluti avatar Oct 15 '24 08:10 Huluti

I'll add myself to the About dialog in another PR. Thank you for saying I'm worth being in there!

ARAKHN1D avatar Oct 16 '24 23:10 ARAKHN1D

Just have rebased the PR @ARAKHN1D Could you add more comments, especially in the “# Manually skip files if necessary” section because the logic is starting to get more complicated. Thank you very much!

Huluti avatar Oct 26 '24 08:10 Huluti

Maybe we could even create a document that explain the process and what we want for the different formats (png, jpg, webp, svg) and the modes (safe, non-safe).

Huluti avatar Oct 26 '24 08:10 Huluti

Yes. I'll add more comments, and if that's not enough I'll create a document.

ARAKHN1D avatar Oct 26 '24 17:10 ARAKHN1D

Thanks a lot. Will do a final check this week to finally merge it.

Huluti avatar Nov 10 '24 13:11 Huluti