RPNSD icon indicating copy to clipboard operation
RPNSD copied to clipboard

some comments

Open sw005320 opened this issue 5 years ago • 2 comments

  • [ ] it's better to acknowledge the faster rcnn repo you used (https://github.com/jwyang/faster-rcnn.pytorch.git) in README.md
  • [ ] add the license information
  • [ ] please take care of CLSP specific parts (e.g., free-gpu -n 1, https://github.com/HuangZiliAndy/RPNSD/blob/master/path.sh#L7-L9, https://github.com/HuangZiliAndy/RPNSD/blob/master/scripts/swbd_sre/prepare_swbd_sre.sh#L13)

sw005320 avatar Jan 20 '20 17:01 sw005320

Hi Shinji,

  • [x] I think I already mentioned my project is largely developed based on https://github.com/jwyang/faster-rcnn.pytorch in the first line of README.md. Do you mean a more formal acknowledgement?
  • [x] add the license information
  • [x] I corrected the problem with submitting jobs and data preparation.

Thanks!

HuangZiliAndy avatar Jan 20 '20 22:01 HuangZiliAndy

oh, i see. i overlooked it. then, that is fine.

sw005320 avatar Jan 20 '20 22:01 sw005320