digitalocean icon indicating copy to clipboard operation
digitalocean copied to clipboard

Add support for bucket and object creation

Open wafflespeanut opened this issue 6 years ago • 5 comments
trafficstars

Addresses #23 and adds necessary stuff for Spaces API.

wafflespeanut avatar Apr 30 '19 20:04 wafflespeanut

I'm planning to implement direct upload and multipart upload for objects, so I don't wanna land this just yet. But, it's ready for first pass! (cc @Hoverbear)

wafflespeanut avatar Apr 30 '19 20:04 wafflespeanut

Seems like the client/builder.rs would be more appropriate as request/builder.rs? (this might require a bit of a structure change for request.rs.)

Hoverbear avatar Apr 30 '19 20:04 Hoverbear

Yep, the modules definitely need some structuring. request/builder.rs makes sense!

wafflespeanut avatar Apr 30 '19 21:04 wafflespeanut

Part of me wonders if some of this codebase can be reduced by using an existing AWS library for some tasks. What do you think?

Hoverbear avatar May 04 '19 21:05 Hoverbear

Part of me wonders if some of this codebase can be reduced by using an existing AWS library for some tasks. What do you think?

rusoto is probably the only maintained AWS lib out there. Their codegen impls futures and streams for all operations. If it makes sensible to you (I don't really have an argument for/against doing this), then we'd wrap over their S3 client and expose only those features that are supported by DO.

wafflespeanut avatar May 12 '19 06:05 wafflespeanut