RedditImageGrab icon indicating copy to clipboard operation
RedditImageGrab copied to clipboard

Made the repository python 3 compatible.

Open arshjat opened this issue 6 years ago • 4 comments

I've made the repository python 3 compatible after doing some major changes in the code. Major difference between what I did and the jtara1 repository is that I did only basic fixes that span up to only 3-4 line changes in reddit.py, 3-4 changes in redditdownload.py and one line change in gfycat.py and it is working perfectly.

Is there any way for my contribution to be taken?

Hoping for a response.

arshjat avatar Nov 12 '18 14:11 arshjat

Do a Pull request, It's unlikely it will be seen since the Dev hasn't updated the code for years. It will need approval, Have no idea if he's still around or not.

It's just better to Fork the Project and just do updates from there.

Revan654 avatar Nov 12 '18 17:11 Revan654

or better use updated fork and recruit people to collaborate

rachmadaniHaryono avatar Nov 12 '18 22:11 rachmadaniHaryono

Thank you @Revan654 and @rachmadaniHaryono for the response, I'll continue with my fork.

arshjat avatar Nov 14 '18 03:11 arshjat

Thank you, I'll continue with my fork.

@arshjat

Not sure if you tested the Script yet, One thing I did notice is (Basing it off of Python 3.7.1):

You have: connection = urllib.urlopen

It Should be: urllib.request.urlopen

I will try it shortly. Grad someone picked it up where Orig. Dev left off.

Revan654 avatar Nov 16 '18 23:11 Revan654