houdini icon indicating copy to clipboard operation
houdini copied to clipboard

feat: Config.exclude can be array

Open DanielHritcu opened this issue 3 years ago • 3 comments

In progress

Fixes #558

Allow passing an array of strings to Config.exclude. Also allow string for this to be a non breaking change.

Should Config.include support arrays as well ?

To help everyone out, please make sure your PR does the following:

  • [x] Update the first line to point to the ticket that this PR fixes
  • [x] Add a message that clearly describes the fix
  • [ ] If applicable, add a test that would fail without this fix
  • [ ] Make sure the unit and integration tests pass locally with pnpm run tests and cd integration && pnpm run tests
  • [ ] Includes a changeset if your fix affects the user with pnpm changeset

DanielHritcu avatar Sep 20 '22 16:09 DanielHritcu

🦋 Changeset detected

Latest commit: ecf743aafa153b47232781cf50f3197bc772023c

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Sep 20 '22 16:09 changeset-bot[bot]

@DanielHritcu is attempting to deploy a commit to the HoudiniGraphQL Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Sep 20 '22 16:09 vercel[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
docs ✅ Ready (Inspect) Visit Preview Oct 4, 2022 at 7:21AM (UTC)
docs-next ✅ Ready (Inspect) Visit Preview Oct 4, 2022 at 7:21AM (UTC)

vercel[bot] avatar Sep 20 '22 18:09 vercel[bot]

I added the code for include, but I can't manage to build the integration project to test.

I get this weird error, and can't figure out why it's thrown.

The files get included, and the artifacts generated.

Can be replicated until my commit here : https://github.com/HoudiniGraphql/houdini/pull/559/commits/f149302df95a2b08277a7ea580ca4979ebc4581d

The error I get:

file: /Users/danielhritcu/GitHub/houdini/integration/$houdini/runtime/lib/index.js:5:9
3: export { errorsToGraphQLLayout } from './errors';
4: export * from './types';
5: export * as log from './log';
            ^
6: export * from './deepEquals';
7: // putting this here was the only way i could find to reliably avoid import issues
[WebServer] error during build:
Error: Parse error @:5:10
    at parse$b (file:///Users/danielhritcu/GitHub/houdini/node_modules/.pnpm/[email protected]/node_modules/vite/dist/node/chunks/dep-665b0112.js:33612:355)
    at Object.transform (file:///Users/danielhritcu/GitHub/houdini/node_modules/.pnpm/[email protected]/node_modules/vite/dist/node/chunks/dep-665b0112.js:42799:27)
Error: Process from config.webServer was not able to start. Exit code: 1

ghost avatar Sep 23 '22 03:09 ghost

@DanielHritcu are you still running into that error?

AlecAivazis avatar Sep 23 '22 20:09 AlecAivazis

@AlecAivazis yes I am.

ghost avatar Sep 24 '22 04:09 ghost

Oh, interesting it's happening on github too - alright so it must be related to your changes since these tests ran successfully in your other PR. I'll try to figure out what's going on

AlecAivazis avatar Sep 25 '22 06:09 AlecAivazis

@DanielHritcu I pushed up a few changes that I think have fixed the problem. I'm really not sure how it's any different from what you have but i'm not getting the errors any more. Let me know what you think

AlecAivazis avatar Sep 27 '22 06:09 AlecAivazis