two_factor_authentication icon indicating copy to clipboard operation
two_factor_authentication copied to clipboard

Published 20 hours ago • verified publisher icon Houdini

Is this project dead?

Open flanger001 opened this issue 4 years ago • 19 comments

The last commit to master was 2019-07-25 and there are lots of open PRs that haven't been acknowledged, https://github.com/Houdini/two_factor_authentication/pull/188 in particular. Additionally there is no activity in the Gitter chat. Is this project dead? Are you accepting new maintainers?

flanger001 avatar Jun 22 '20 20:06 flanger001

@Houdini a quick ping on this – thanks for your work maintaining this library so far. Before submitting a PR to fix a bug I've found, I want to make sure the project is active and accepting contributions?

steobrien avatar Sep 02 '20 17:09 steobrien

I would be open to taking ownership of this repo to oversee further development.

anasteele206 avatar Nov 24 '20 22:11 anasteele206

@Houdini sorry to pile on in this PR, but it'd be helpful to know the state of this library.

jherdman avatar Jan 12 '21 15:01 jherdman

I think the best option here is going to be forking unfortunately.

flanger001 avatar Jan 14 '21 17:01 flanger001

I will be happy to fork this into a new organization and give people maintainer access on it.

flanger001 avatar Jan 19 '21 19:01 flanger001

@flanger001 Can you please let me know if any forked library supports rails 6.1, happy to contribute @Houdini

sudhindra avatar Jun 25 '21 05:06 sudhindra

@sudhindra I opened a PR a while ago for the Rails 6 stuff. You could fork your own project and steal the PRs you need.

jasonperrone avatar Sep 13 '21 19:09 jasonperrone

Sorry, it wasn't me who did that PR. Losing track because I am finding I have to fix a lot of gems lately for either Rails 6.1 compatibility or Ruby 3 compatibility https://github.com/Houdini/two_factor_authentication/pull/204

jasonperrone avatar Sep 13 '21 19:09 jasonperrone

@Houdini do you think we could add a few more people to this as maintainers?

kengreeff avatar Feb 01 '22 01:02 kengreeff

Have forked this here https://github.com/baarkerlounger/two_factor_authentication for the time being (happy to create PRs from that here or have commits cherry-picked if that helps, if this repo gets going again). Works in testing so far with Rails 7 and Turbo, and specs run again.

baarkerlounger avatar Feb 08 '22 23:02 baarkerlounger

@baarkerlounger thanks a lot!

strzibny avatar Feb 09 '22 16:02 strzibny

Seems like no movement in this repo still. Given that, would anyone else like to help maintain a fork :point_up:? What do people think about publishing to RubyGems? (Would need a new name presumably).

baarkerlounger avatar Mar 16 '22 09:03 baarkerlounger

I actually decided to fix https://github.com/wmlele/devise-otp. It now works for Rails 7 and the only thing missing is updating README and doing a proper release. So if someone needs maintained and up to date OTP solution join us :). I got commit and RubyGems push rights from the original dev, so no blockers.

strzibny avatar Mar 16 '22 09:03 strzibny

@strzibny any major advantages to that project over this one?

baarkerlounger avatar Mar 16 '22 10:03 baarkerlounger

Not really, although I am not sure if two_factor_authentication ships with JavaScript QR code library to show the image. I like it since it's simple, small codebase, and we used it at work (I maintained Rails 5 fork before going to fix it for Rails 7).

strzibny avatar Mar 16 '22 10:03 strzibny

Thanks @strzibny (love Deployment From Scratch btw) and @baarkerlounger for taking care of this stuff - I actually did end up forking it into a new org myself: https://github.com/devise2fa/two_factor_authentication - but I never did anything with it afterwards because I felt the whole thing of cutting a gem was going to be a pain. However, if anyone wants to get in and actually do it, I'll happily turn over the org.

flanger001 avatar Mar 16 '22 17:03 flanger001

Thanks @flanger001!

Btw I just released devise-otp 0.3.0 which I use with Rails 7 and Hotwire.

strzibny avatar Mar 19 '22 16:03 strzibny

@flanger001 I submitted a pull request to your repo with all the changes I made on my fork. Any interest in merging and releasing as a new gem still? (Happy to be added as a maintainer also), or are you moving on to devise-otp rather?

baarkerlounger avatar Apr 10 '22 11:04 baarkerlounger

@baarkerlounger I'm very sorry! I just got this and I will respond to you there!

flanger001 avatar Apr 13 '22 15:04 flanger001