Martin Hochel

Results 128 comments of Martin Hochel

just curious, can you provide some official docs or article where are they using NgModule class constructor for this kind of instantiation ? thx

## implementation Notes: - when `bundle` is called it should register ng1 `.run` hook with properly annotated injectables

So that's interesting idea. Unfortunately all efforts you've linked have failed so far... What is more doable IMHO is implementing propTypes like React has (runtime type checking) There were some...

What I meant is not incorporating all mentioned tooling within stencil server, rather creating separate npm-scripts tags within this project -> prettier + tslint with applied fixes would be triggered...

@garth what you should do in case of importing react stuff is following: **tsonfig:** ```json { "compileOptions": { "allowSyntheticDefaultImports": true, "esModuleInterop": true } } ``` now you can: ```ts import...

I would mark this as high priority. Test are mandatory thing for anyone who want's to start developing with skate. We are currently struggling with it at work

It would be better to have here @elmariofredo who was responsible to setup tests with skate. We eventually ended with https://github.com/Polymer/web-component-tester

hmm this is not very good example from perf perspective > In the end, @import is still an anti-pattern and can be a performance problem in web components. So, it’s...

Hmm We are shipping it inline for instance, not the best way from Perf perspective, but the only viable at this moment for us https://github.com/wc-catalogue/blaze-elements/blob/master/packages/button/Button.tsx#L50 About the ShadowDom, without it...

So maybe we should include both your solution and ours within docs, WDYT ?