hotcakes-commerce-core icon indicating copy to clipboard operation
hotcakes-commerce-core copied to clipboard

Get store by cache updates

Open mtrutledge opened this issue 4 years ago • 3 comments

I find that New relic frequently reports a high number of SQL calls when getting the Store by GUID or by ID. This update uses the CacheManager to get the store when calling FindStoreById, FindStoreByGuid, and FindStoreByCustomUrl.

mtrutledge avatar Jan 26 '22 21:01 mtrutledge

Thanks, Matt! I don't see an open issue for this update. I'm curious... Am I missing it for some reason, or did you just do the PR without one? 🙂

WillStrohl avatar Jan 27 '22 23:01 WillStrohl

I did the PR without one. I can create an issue if necessary.

On Thu, Jan 27, 2022 at 4:52 PM Will Strohl @.***> wrote:

Thanks, Matt! I don't see an open issue for this update. I'm curious... Am I missing it for some reason, or did you just do the PR without one? 🙂

— Reply to this email directly, view it on GitHub https://github.com/HotcakesCommerce/hotcakes-commerce-core/pull/388#issuecomment-1023747401, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAQIT7XWDJJXMXCAC3MMHLTUYHLCTANCNFSM5M4FQ2XA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

mtrutledge avatar Jan 27 '22 23:01 mtrutledge

Fixes #389

I have created an issue/feature that relates to this PR!

mtrutledge avatar Feb 01 '22 21:02 mtrutledge