Hossein Yousefi

Results 155 comments of Hossein Yousefi

More use cases: ### Renaming without breaking user's code We could rename and deprecate. The previously used names (stored in a json file), can still work but be annotated with...

> Isn't the import name added to renaming context, (causing the method name to be renamed)? No, I didn't change the renaming logic, it has been like this. Plus, I...

> Big +1 for doing the first two! > > That would be similar to what Kotlin to Java interop does: https://kotlinlang.org/docs/java-interop.html#getters-and-setters Kotlin is doing some other conversions for operators...

This is mostly done. We don't support comments, but it seems that Android libraries also use annotations for example: https://cs.opensource.google/exoplayer/ExoPlayer/+/release-v2:library/ui/src/main/java/com/google/android/exoplayer2/ui/PlayerView.java;l=553

We probably want to do this after 1.0. I'll keep it in the backlog.

I made this repo for various benchmarks. Different branches contain different experiments. https://github.com/HosseinYousefi/jnigen_benchmark Adding this to 1.0.0 milestone to make sure the CI runs benchmarks and provides reports.

This is a good idea, however it's not a priority for now. The number one use case of `package:jni` is going to be for Flutter Android.

Native assets are still in experimental. Moving this backlog.

No worries, was just letting you know because you worked on the gradle stuff. It's not a pressing issue, but still useful to solve. Will ask around!

> IsSameObject - should we overload == to call IsSameObject from JNI? (Different ref values can point to same object). `isSameObject` can be its own method. In the branch I'm...