hospitalrun-frontend
hospitalrun-frontend copied to clipboard
fix: align cancel button
Fixes #2765.
Changes proposed in this pull request:
- Align cancel buttons to the left in following 8 files:-
- src/imagings/requests/NewImagingRequest.tsx
- src/incidents/report/ReportIncident.tsx
- src/labs/requests/NewLabRequest.tsx
- src/medications/requests/NewMedicationRequest.tsx
- src/patients/edit/EditPatient.tsx
- src/patients/new/NewPatient.tsx
- src/scheduling/appointments/edit/EditAppointment.tsx
- src/scheduling/appointments/new/NewAppointment.tsx
This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.
🔍 Inspect: https://vercel.com/hospitalrun/hospitalrun-frontend/6f5NZ9hHVm3xHEvn4u7kQNjFJABf
✅ Preview: https://hospitalrun-frontend-git-fork-kaushikpallavi-cee1ec-hospitalrun.vercel.app
Tested the UI and looks good. @kaushikpallavi7 but can you fix the title to match the semantic?
FIX: Cancel button align
Tested the UI and looks good. @kaushikpallavi7 but can you fix the title to match the semantic?
FIX: Cancel button align
Thanks @RobertoMSousa , I have changed the PR title.
The PR does what's expected but the number of changes (8 files) to do exactly the same suggests that this should be a component with those 2 buttons.
Will commit with this change 👍🏻
Tested the UI and looks good. @kaushikpallavi7 but can you fix the title to match the semantic?
FIX: Cancel button align
Thanks @RobertoMSousa , I have changed the PR title.
@kaushikpallavi7 remember to use commit message like this: fix: fixes something
or fix(layout): fixes something
Great work @kaushikpallavi7! As mentioned by @RobertoMSousa, it should be good to go after these 2 buttons are under a shared component.
Thanks a lot. I started that change but didn't get much time. I will submit that change in a day or two.
Tested the UI and looks good. @kaushikpallavi7 but can you fix the title to match the semantic?
FIX: Cancel button align
Thanks @RobertoMSousa , I have changed the PR title.
@kaushikpallavi7 remember to use commit message like this:
fix: fixes something
orfix(layout): fixes something
Yes will take care from future. Thanks a lot for correcting @tehKapa
Great work @kaushikpallavi7! As mentioned by @RobertoMSousa, it should be good to go after these 2 buttons are under a shared component.
I see you have started changes. I had also extracted buttons in a separate component. Only tests are pending. Shall I push with these changes?
@kaushikpallavi7 , are you still working on this? There's no activity for a while
@kaushikpallavi7 , are you still working on this? There's no activity for a while
I saw someone also started changes, so I didn't put mine. Will raise the PR by tomorrow.
Deployment failed with the following error:
Resource is limited - try again after in 21 hours (more than 100, code: "api-deployments-free-per-day").
Deployment failed with the following error:
Resource is limited - try again after in 15 minutes (more than 100, code: "api-deployments-free-per-day").