hospitalrun-frontend
hospitalrun-frontend copied to clipboard
HospitalRun
fix(lab): enforce the visit field when create lab
Fixes #2557
Changes proposed in this pull request:
- validate the
visitfield when saving the Lab.
This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.
🔍 Inspect: https://vercel.com/hospitalrun/hospitalrun-frontend/Asi5tKLsXTrxsh3FjGBuY1XTqH6s
✅ Preview: https://hospitalrun-frontend-git-fork-samuelqzq-test-hospitalrun.vercel.app
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
Just had a quick peek @SamuelQZQ you might still be busy with this, it looks like the required message does not display yet?
See report incident example showing all required fields messages if all of them are not filled in
@blestab The visit field is implemented with the Select component from @hospitalrun/components. Which does not have the functionality to display the error message. The other input fields are implemented with the TextInput component which can display the error message.
Any suggestion? Should I create a PR for the component Repo?
@blestab @jackcmeyer Any response?
The Select component cannot show the error message. Should I make the change in the Component repo first?
@blestab @jackcmeyer Any response? The
Selectcomponent cannot show the error message. Should I make the change in the Component repo first?
@SamuelQZQ, sorry been offline. I'll create a new issue in the components repo for you to fix the component to also display an error message when needed. Once that is done you can then resume work on this one to use the components changes? Will that work for you?
@blestab Sounds good.
https://github.com/HospitalRun/components/issues/689 has been created for you @SamuelQZQ
@SamuelQZQ select component has been merged https://github.com/HospitalRun/components/pull/690
@SamuelQZQ sorry about delay, but the project is unfortunately back in a "frozen state". can you fix conflicts? thanks!