hospitalrun-frontend icon indicating copy to clipboard operation
hospitalrun-frontend copied to clipboard

New Lab Request - required visit not enforced

Open blestab opened this issue 3 years ago • 2 comments

This is a follow-up to #2551 (see https://github.com/HospitalRun/hospitalrun-frontend/pull/2552#pullrequestreview-576596693 ) and can only be started once the linked PR has been merged in.

When requesting a new lab, visit is required but a user can still save without choosing a visit.

🐛 Bug Report

When creating a new lab request, a user should not be able to save without specifying a visit.

To Reproduce

Go to staging https://staging.hospitalrun.io/ Create a new patient and create one visit for this patient Create a new lab request leaving the visit field empty Notice you are allowed to save even though the visit is marked as required

Expected behavior

User should not be able to save a New Imaging request without selecting a visit.

Reference

See how the Patient or Type field are handled and do the same

Your Environment

  • node version: 6,8,10
  • fastify version: >=1.0.0
  • os: Mac, Windows, Linux
  • any other relevant information

blestab avatar Jan 27 '21 08:01 blestab

@blestab Can I be assigned to this task?

SamuelQZQ avatar Jan 27 '21 08:01 SamuelQZQ

@blestab Can I be assigned to this task?

All yours @SamuelQZQ

blestab avatar Jan 27 '21 08:01 blestab