HospitalRun
New Imaging Request - required visit not enforced
When requesting a new imaging, visit is required but a user can still save without choosing a visit. See https://github.com/HospitalRun/hospitalrun-frontend/pull/2552#pullrequestreview-576596693
🐛 Bug Report
When creating a new imaging request, a user should not be able to save without specifying a visit.
To Reproduce
Go to staging https://staging.hospitalrun.io/ Create a new patient and create one visit for this patient Create a new imaging request leaving the visit field empty Notice you are allowed to save even though the visit is marked as required
Expected behavior
User should not be able to save a New Imaging request without selecting a visit.
Reference
See how the Patient or Type field are handled and do the same
Your Environment
- node version: 6,8,10
- fastify version: >=1.0.0
- os: Mac, Windows, Linux
- any other relevant information
@blestab Can I be assigned to this task?
Thank you @SamuelQZQ, Let's get #2557 out first then will assign this to you once done.
Hi, Sorry I'm getting in the way :)
"See how the Patient or Type field are handled and do the same"
In this case I don't think it's okay to manage them in the same way, with which search criteria would you do it? I don't think it would be good to even see them all. It would be necessary to decide with which criteria to show the visits.
Hi, Sorry I'm getting in the way :)
"See how the Patient or Type field are handled and do the same"
In this case I don't think it's okay to manage them in the same way, with which search criteria would you do it? I don't think it would be good to even see them all. It would be necessary to decide with which criteria to show the visits.
Thanks @alexma01, you're not in the way at all, all ideas are welcome; Why don't you hop onto our slack and tell us more about your thoughts about this
@bernoraj currently I'm afraid it's stuck. if you want to take it over, you're welcome to it
