Sidechains-SDK icon indicating copy to clipboard operation
Sidechains-SDK copied to clipboard

SidechainHistoryStorage, SidechainHistory data retrieving methods naming

Open i-Alex opened this issue 4 years ago • 0 comments

In SidechainHistoryStorage, SidechainHistory and other places when we want and expect to retrieve an instance of A by some B, we should have a method: def getAbyB(b: B): A That should return A or throw an exception.

When we expect that A can not exist for existing B, we should have a method: def getAbyBOption(b: B): Option[A] At the moment such a method names are not consistent. Need to review and change in all places, where is needed.

i-Alex avatar Apr 16 '20 14:04 i-Alex