MineCraft-One-Week-Challenge icon indicating copy to clipboard operation
MineCraft-One-Week-Challenge copied to clipboard

Published 20 hours ago • verified publisher icon Hopson97

Fixed block coord bug.

Open lhinuz opened this issue 6 years ago • 3 comments

Fixed block coord bug.

lhinuz avatar May 21 '19 06:05 lhinuz

Not sure if this commit actually does anything, just seems to add unnecessary extra math.

DreamHollow avatar Mar 01 '23 21:03 DreamHollow

Yeah, I might see if I can test this to see if there is a difference; not sure what this actually is fixing without additional context

Hopson97 avatar Mar 02 '23 09:03 Hopson97

The % operator is a division remainder and negative numbers stay negative. With the fix they'll be positive so it'll be an actual modulo. A stack overflow answer about it

Double modulo may not be the best idea if that code should be very optimised though.

janvanbouwel avatar Mar 22 '23 01:03 janvanbouwel