pdf-lib icon indicating copy to clipboard operation
pdf-lib copied to clipboard

Fix bug in SVG path command T #1443

Open ralfstx opened this issue 1 year ago • 4 comments

The control point (px, py) is already updated in the else branch above (L271). It is then updated once again which causes bug #1443.

This commit removes these duplicated lines which fixes the bug.

What?

Why?

How?

Testing?

New Dependencies?

Screenshots

Suggested Reading?

Anything Else?

Checklist

  • [ ] I read CONTRIBUTING.md.
  • [ ] I read MAINTAINERSHIP.md#pull-requests.
  • [ ] I added/updated unit tests for my changes.
  • [ ] I added/updated integration tests for my changes.
  • [ ] I ran the integration tests.
  • [ ] I tested my changes in Node, Deno, and the browser.
  • [ ] I viewed documents produced with my changes in Adobe Acrobat, Foxit Reader, Firefox, and Chrome.
  • [ ] I added/updated doc comments for any new/modified public APIs.
  • [ ] My changes work for both new and existing PDF files.
  • [ ] I ran the linter on my changes.

ralfstx avatar Apr 23 '23 17:04 ralfstx

Would you mind checking if this bug seems necessary in @cantoo/pdf-lib ? Waiting for Hopding to have the time to keep up with the contributions here, we made our fork that we try to maintain there.

Sharcoux avatar Sep 29 '23 22:09 Sharcoux

@Sharcoux Here you go: https://github.com/cantoo-scribe/pdf-lib/pull/30

ralfstx avatar Oct 02 '23 22:10 ralfstx

Does this have chance to be fixed?

laszlo1337 avatar Jan 17 '24 10:01 laszlo1337

This has been released in @cantoo/pdf-lib

Sharcoux avatar Jan 17 '24 14:01 Sharcoux