homebrew-test-bot
homebrew-test-bot copied to clipboard
feat: detect all package changes
This should allow us to use this flow in homebrew/cask too.
Please provide a better issue/pull request title and/or description!
Doesn't every tap use this function by default? That would be a lot of people who suddenly have their tap broken if we remove the formulae_ variables.
I'm fine splitting up the variables and/or making a combination. But just to make sure: you're only talking about this method right? You're not looking for me to add casks to all flags in this PR.
Doesn't every tap use this function by default? That would be a lot of people who suddenly have their tap broken if we remove the
formulae_variables.
It does but we can/should change that in Homebrew/brew and add a deprecation.
I'm fine splitting up the variables and/or making a combination. But just to make sure: you're only talking about this method right? You're not looking for me to add casks to all flags in this PR.
I think it's fine to have for now but I guess I'm a little confused as to how it ends up being useful when only detection is done and nothing else?
Since detection is a separate step, it allows me to move another part of cask CI to testbot.
Everything after that will take more work so I'd like to do them separately
Since detection is a separate step, it allows me to move another part of cask CI to testbot.
Ok, makes sense. If it's useful as-is: great.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Updated to be specific to casks.
Good to 🚢 when CI is 🟢
I have no clue why CI could be failing, as far as I can tell it should be bright green
Invalid usage: Did not find any formulae or commits to test!
Looks like CI is perhaps legitimately broken.