homebrew-test-bot icon indicating copy to clipboard operation
homebrew-test-bot copied to clipboard

feat: detect all package changes

Open SMillerDev opened this issue 1 year ago • 9 comments

This should allow us to use this flow in homebrew/cask too.

SMillerDev avatar Jan 31 '24 12:01 SMillerDev

Please provide a better issue/pull request title and/or description!

request-info[bot] avatar Jan 31 '24 12:01 request-info[bot]

Doesn't every tap use this function by default? That would be a lot of people who suddenly have their tap broken if we remove the formulae_ variables.

I'm fine splitting up the variables and/or making a combination. But just to make sure: you're only talking about this method right? You're not looking for me to add casks to all flags in this PR.

SMillerDev avatar Feb 06 '24 15:02 SMillerDev

Doesn't every tap use this function by default? That would be a lot of people who suddenly have their tap broken if we remove the formulae_ variables.

It does but we can/should change that in Homebrew/brew and add a deprecation.

I'm fine splitting up the variables and/or making a combination. But just to make sure: you're only talking about this method right? You're not looking for me to add casks to all flags in this PR.

I think it's fine to have for now but I guess I'm a little confused as to how it ends up being useful when only detection is done and nothing else?

MikeMcQuaid avatar Feb 12 '24 14:02 MikeMcQuaid

Since detection is a separate step, it allows me to move another part of cask CI to testbot.

Everything after that will take more work so I'd like to do them separately

SMillerDev avatar Feb 12 '24 14:02 SMillerDev

Since detection is a separate step, it allows me to move another part of cask CI to testbot.

Ok, makes sense. If it's useful as-is: great.

MikeMcQuaid avatar Feb 12 '24 15:02 MikeMcQuaid

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar Mar 05 '24 00:03 github-actions[bot]

Updated to be specific to casks.

SMillerDev avatar Mar 23 '24 17:03 SMillerDev

Good to 🚢 when CI is 🟢

MikeMcQuaid avatar Mar 25 '24 14:03 MikeMcQuaid

I have no clue why CI could be failing, as far as I can tell it should be bright green

SMillerDev avatar Apr 02 '24 14:04 SMillerDev

Invalid usage: Did not find any formulae or commits to test!

Looks like CI is perhaps legitimately broken.

MikeMcQuaid avatar Apr 22 '24 12:04 MikeMcQuaid