homebrew-core icon indicating copy to clipboard operation
homebrew-core copied to clipboard

aws-vault 7.3.7

Open mbevc1 opened this issue 6 months ago • 7 comments

Change to maintained fork and bump version

  • [x] Have you followed the guidelines for contributing?
  • [x] Have you ensured that your commits follow the commit style guide?
  • [x] Have you checked that there aren't other open pull requests for the same formula update/change?
  • [x] Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • [x] Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • [x] Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

mbevc1 avatar Jun 09 '25 09:06 mbevc1

I think you should submit as a new formula, not changing previous one. It is not an official descendant.

daeho-ro avatar Jun 09 '25 10:06 daeho-ro

Project seems abandoned and no response from maintainers for a while. It's a in-place replacement and direct fork. Could we at least retire this and add new one? Otherwise the naming might be overlapping.

mbevc1 avatar Jun 09 '25 11:06 mbevc1

Here is our policy to accept forks.

  • https://docs.brew.sh/Acceptable-Formulae#not-a-fork-usually

daeho-ro avatar Jun 09 '25 11:06 daeho-ro

You could add your own tap to use the same formula name, then the full name of the formula will be

brew install your-org/your-tap/aws-vault
  • https://docs.brew.sh/How-to-Create-and-Maintain-a-Tap

daeho-ro avatar Jun 09 '25 11:06 daeho-ro

Thanks for the suggestion, but I'm not sure I want to maintain my own tap ATM :thinking:

mbevc1 avatar Jun 09 '25 11:06 mbevc1

What'd be suggestion in case project is dead and we cannot get updates upstream anymore?

mbevc1 avatar Jun 09 '25 11:06 mbevc1

In case we can get a response from anyone at upstream (if maintainers will respond) I've opened: https://github.com/99designs/aws-vault/pull/1270

mbevc1 avatar Jun 09 '25 14:06 mbevc1

:robot: An automated task has requested bottles to be published to this PR.

Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch.

github-actions[bot] avatar Jun 23 '25 05:06 github-actions[bot]

Thanks @mbevc1!

chenrui333 avatar Jun 23 '25 05:06 chenrui333