homebrew-core
homebrew-core copied to clipboard
edit 1.1.0 (new formula)
- [x] Have you followed the guidelines for contributing?
- [x] Have you ensured that your commits follow the commit style guide?
- [x] Have you checked that there aren't other open pull requests for the same formula update/change?
- [ ] Have you built your formula locally with
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting? Only on a Linux environment. - [x] Is your test running fine
brew test <formula>, where<formula>is the name of the formula you're submitting? - [ ] Does your build pass
brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?
Thanks for contributing to Homebrew! :tada: It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
This was working good with homebrew docker but fails on CI.
This was working good with homebrew docker but fails on CI.
It appears to pass on Mac but fail on Linux with:
==> /home/linuxbrew/.linuxbrew/Cellar/msedit/1.2.0/bin/edit --version
Error 6: No such device or address
I'm also confused but perhaps you could tree the formula dir beforehand to debug its contents?
Any way to test/use the formula on MacOS?
:robot: An automated task has requested bottles to be published to this PR.
[!CAUTION] Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch.
🚀
@chenrui333 I'm confused why this was merged? Due to the force pushes the old reviews are hidden but:
- https://github.com/Homebrew/homebrew-core/pull/225837#discussion_r2309387486: binary should be renamed on both Mac and Linux
- https://github.com/Zoobdude/homebrew-core/blob/c6b0cf4a0627a16879a21a9168bf2e88ef154b6b/Formula/m/msedit.rb#L16: Linux was skipped rather than debug CI
- https://github.com/Zoobdude/homebrew-core/blob/c6b0cf4a0627a16879a21a9168bf2e88ef154b6b/Formula/m/msedit.rb#L25: test was never updated
- Version 1.2.0 in particular errors on Mac :
Word search also errors related to ICU. (Fixed in 1.2.1)
- I'm confused why it builds successfully at all (but maybe I just don't understand homebrew dependencies):
It only worked with Rust nightly (in their readme) when I built locally?
I'd love Edit to be installable by Homebrew but this PR felt unfinished (no shade on its contributor).