homebrew-core icon indicating copy to clipboard operation
homebrew-core copied to clipboard

protobuf 30.1

Open BrewTestBot opened this issue 9 months ago • 3 comments

Created by brew bump


Created with brew bump-formula-pr.


TODO, split out Protobuf 29 downgrades

  • [x] mysql / percona-server - #211057
  • [ ] ola
  • [ ] or-tools

Blocked by Linux formulae that fail with Check failed: GeneratedDatabase()->Add(encoded_file_descriptor, size)

  • [ ] ola (only has direct dependency on protobuf@29)
      ==> /home/linuxbrew/.linuxbrew/Cellar/ola/0.10.9_6/bin/ola_plugin_state -h
      WARNING: All log messages before absl::InitializeLog() is called are written to STDERR
      E0000 00:00:1741969269.420588  197450 descriptor_database.cc:550] Invalid file descriptor data passed to EncodedDescriptorDatabase::Add().
      F0000 00:00:1741969269.420711  197450 descriptor.cc:2248] Check failed: GeneratedDatabase()->Add(encoded_file_descriptor, size) 
      *** Check failure stack trace: ***
    
  • [ ] openvino (has multiple dependencies on protobuf from direct and onnx)
      ==> /tmp/openvino-test-20250314-60982-58fy40/openvino_frontends_test
      WARNING: All log messages before absl::InitializeLog() is called are written to STDERR
      E0000 00:00:1741966434.971057   61124 descriptor_database.cc:635] File already exists in database: 
      F0000 00:00:1741966434.972610   61124 descriptor.cc:2265] Check failed: GeneratedDatabase()->Add(encoded_file_descriptor, size) 
      *** Check failure stack trace: ***
    
  • [ ] opencv (has multiple dependencies on protobuf from direct, openvino and onnx)
      ==> python3.13 -c 'import cv2; print(cv2.__version__)'
      WARNING: All log messages before absl::InitializeLog() is called are written to STDERR
      E0000 00:00:1741975112.242688  244594 descriptor_database.cc:552] Invalid file descriptor data passed to EncodedDescriptorDatabase::Add().
      F0000 00:00:1741975112.242769  244594 descriptor.cc:2265] Check failed: GeneratedDatabase()->Add(encoded_file_descriptor, size) 
      *** Check failure stack trace: ***
    
  • [ ] or-tools (only has direct dependency on protobuf)
      ==> ./simple_lp_program
      WARNING: All log messages before absl::InitializeLog() is called are written to STDERR
      E0000 00:00:1741976060.120565  258906 descriptor_database.cc:635] File already exists in database: 
      F0000 00:00:1741976060.120701  258906 descriptor.cc:2265] Check failed: GeneratedDatabase()->Add(encoded_file_descriptor, size) 
      *** Check failure stack trace: ***
    
  • [ ] pytorch
      WARNING: All log messages before absl::InitializeLog() is called are written to STDERR
      E0000 00:00:1741988015.358958  434809 descriptor_database.cc:552] Invalid file descriptor data passed to EncodedDescriptorDatabase::Add().
      F0000 00:00:1741988015.359246  434809 descriptor.cc:2265] Check failed: GeneratedDatabase()->Add(encoded_file_descriptor, size) 
      *** Check failure stack trace: ***
    

Backports:

  • netdata - https://github.com/netdata/netdata/commit/a6cc2215f49be2f862cbd8747555b561dc0d6eef
  • protobuf-c - https://github.com/protobuf-c/protobuf-c/commit/25174818178d4761f971dab1c47083b892297dc2

Workarounds:

  • openvino - add workaround to allow newer Protobuf. Need to report upstream

Follow ups to report upstream:

  • [ ] brpc
  • [ ] libpulsar - https://github.com/apache/pulsar-client-cpp/issues/478
  • [ ] openvino
  • [ ] protoc-gen-grpc-web
  • [ ] protoc-gen-js
  • [ ] mysql / percona-server

BrewTestBot avatar Mar 13 '25 23:03 BrewTestBot

Linux is going to be the blocker as we've been hitting some error for a while now (e.g. OpenCV PRs like #208693) which is showing up here:

  ==> /home/linuxbrew/.linuxbrew/Cellar/ola/0.10.9_6/bin/ola_plugin_state -h
  WARNING: All log messages before absl::InitializeLog() is called are written to STDERR
  E0000 00:00:1741969269.420588  197450 descriptor_database.cc:550] Invalid file descriptor data passed to EncodedDescriptorDatabase::Add().
  F0000 00:00:1741969269.420711  197450 descriptor.cc:2248] Check failed: GeneratedDatabase()->Add(encoded_file_descriptor, size) 
  *** Check failure stack trace: ***
  ==> /tmp/openvino-test-20250314-60982-58fy40/openvino_frontends_test
  WARNING: All log messages before absl::InitializeLog() is called are written to STDERR
  E0000 00:00:1741966434.971057   61124 descriptor_database.cc:635] File already exists in database: 
  F0000 00:00:1741966434.972610   61124 descriptor.cc:2265] Check failed: GeneratedDatabase()->Add(encoded_file_descriptor, size) 

cho-m avatar Mar 14 '25 15:03 cho-m

Protobuf 30.2 is available

botantony avatar May 01 '25 15:05 botantony

brew install --HEAD protobuf
Error: No head is defined for protobuf

I am trying to install 31.1

brew install [email protected]
Warning: No available formula with the name "[email protected]". Did you mean protobuf@3 or protobuf@21?
==> Searching for similarly named formulae and casks...
==> Formulae
protobuf@3                                                                                                protobuf@21

To install protobuf@3, run:
  brew install protobuf@3

Any idea how I suppose to do that?

yordis avatar Jun 05 '25 21:06 yordis

previously, https://github.com/Homebrew/homebrew-core/commits/41940fa56d1f7df7a425596868fc935d55013d6b

chenrui333 avatar Jun 22 '25 00:06 chenrui333

I believe the PR https://github.com/Homebrew/homebrew-core/pull/227847 is unnecessary -- I tried to run the failing test against protobuf 30.1 and it passes. Looking at the test, it does something silly: it looks if runtime was more than 1 wallclock second, and if so, fails. I think the runner was just busy. I'll make a note to fix this test, but in the meantime, please retry with protobuf 30.1 for mosh.

achernya avatar Jun 23 '25 21:06 achernya

Closing this in favour of https://github.com/Homebrew/homebrew-core/pull/228410

SMillerDev avatar Jul 22 '25 14:07 SMillerDev