homebrew-core icon indicating copy to clipboard operation
homebrew-core copied to clipboard

ocaml 5.3.0

Open bayandin opened this issue 11 months ago • 6 comments

Created with brew bump-formula-pr.

bayandin avatar Jan 19 '25 20:01 bayandin

 # (cd _build/default && /private/tmp/opamroot20250121-51676-qnp7ck/default/bin/ocamlc.opt -w -9 -g -bin-annot -I astlib/.astlib.objs/byte -I /private/tmp/opamroot20250121-51676-qnp7ck/default/lib/ocaml-compiler-libs/common -I /private/tmp/opamroot20250121-51676-qnp7ck/default/lib/ocaml/compiler-libs -no-alias-deps -open Astlib__ -o astlib/.astlib.objs/byte/astlib__Ast_501.cmo -c -impl astlib/as[...]
  # File "astlib/ast_501.ml", lines 245-299, characters 2-44:
  # Error: This variant or record definition does not match that of type
  #          Parsetree.pattern_desc
  #        An extra constructor, Ppat_effect, is provided in the original definition.

notxvilka avatar Jan 22 '25 16:01 notxvilka

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

github-actions[bot] avatar Jan 25 '25 00:01 github-actions[bot]

ppxlib (0.35.0) doesn't build for:

  • brew install --build-from-source haxe
    #=== ERROR while compiling ppxlib.0.35.0 ======================================#
      # context              2.3.0 | macos/arm64 | ocaml.5.1.1 | [https://opam.ocaml.org#278df338effcd8a80241fbf6902ef949a850372c](https://opam.ocaml.org/#278df338effcd8a80241fbf6902ef949a850372c)
      # path                 /private/tmp/opamroot20250205-96729-pkvquj/default/.opam-switch/build/ppxlib.0.35.0
      # command              /private/tmp/opamroot20250205-96729-pkvquj/default/bin/dune build -p ppxlib -j 3 @install
      # exit-code            1
      # env-file             /private/tmp/opamroot20250205-96729-pkvquj/log/ppxlib-17483-024693.env
      # output-file          /private/tmp/opamroot20250205-96729-pkvquj/log/ppxlib-17483-024693.out
      ### output ###
      # (cd _build/default && /private/tmp/opamroot20250205-96729-pkvquj/default/bin/ocamlc.opt -w -9 -g -bin-annot -I astlib/.astlib.objs/byte -I /private/tmp/opamroot20250205-96729-pkvquj/default/lib/ocaml-compiler-libs/common -I /private/tmp/opamroot20250205-96729-pkvquj/default/lib/ocaml/compiler-libs -no-alias-deps -open Astlib__ -o astlib/.astlib.objs/byte/astlib__Ast_[501](https://github.com/Homebrew/homebrew-core/actions/runs/13162848833/job/36742073581?pr=204847#step:3:502).cmo -c -impl astlib/as[...]
      # File "astlib/ast_501.ml", lines 245-299, characters 2-44:
      # Error: This variant or record definition does not match that of type
      #          Parsetree.pattern_desc
      #        An extra constructor, Ppat_effect, is provided in the original definition.
    
  • brew install --build-from-source stanc3
    #=== ERROR while compiling ppxlib.0.35.0 ======================================#
      # context              2.3.0 | macos/arm64 | ocaml.5.1.1 | [https://opam.ocaml.org#278df338effcd8a80241fbf6902ef949a850372c](https://opam.ocaml.org/#278df338effcd8a80241fbf6902ef949a850372c)
      # path                 /private/tmp/opamroot20250205-51270-9kwpiq/default/.opam-switch/build/ppxlib.0.35.0
      # command              /private/tmp/opamroot20250205-51270-9kwpiq/default/bin/dune build -p ppxlib -j 3 @install
      # exit-code            1
      # env-file             /private/tmp/opamroot20250205-51270-9kwpiq/log/ppxlib-51452-14d2e2.env
      # output-file          /private/tmp/opamroot20250205-51270-9kwpiq/log/ppxlib-51452-14d2e2.out
      ### output ###
      # (cd _build/default && /private/tmp/opamroot20250205-51270-9kwpiq/default/bin/ocamlc.opt -w -9 -g -bin-annot -I astlib/.astlib.objs/byte -I /private/tmp/opamroot20250205-51270-9kwpiq/default/lib/ocaml-compiler-libs/common -I /private/tmp/opamroot20250205-51270-9kwpiq/default/lib/ocaml/compiler-libs -no-alias-deps -open Astlib__ -o astlib/.astlib.objs/byte/astlib__Ast_501.cmo -c -impl astlib/as[...]
      # File "astlib/ast_501.ml", lines 245-299, characters 2-44:
      # Error: This variant or record definition does not match that of type
      #          Parsetree.pattern_desc
      #        An extra constructor, Ppat_effect, is provided in the original definition.
    

coq-stdlib (8.20.1) doesn't build for:

  • brew install --build-from-source ott
    #=== ERROR while compiling coq-stdlib.8.20.1 ==================================#
      # context              2.3.0 | macos/arm64 | ocaml.5.3.0 | [https://opam.ocaml.org#278df338effcd8a80241fbf6902ef949a850372c](https://opam.ocaml.org/#278df338effcd8a80241fbf6902ef949a850372c)
      # path                 /private/tmp/ott-20250205-57949-b5rofy/ott-0.34/.opam/default/.opam-switch/build/coq-stdlib.8.20.1
      # command              /opt/homebrew/Library/Homebrew/shims/mac/super/make dunestrap COQ_DUNE_EXTRA_OPT=-split DUNESTRAPOPT=-p coq-stdlib
      # exit-code            2
      # env-file             /private/tmp/ott-20250205-57949-b5rofy/ott-0.34/.opam/log/coq-stdlib-58087-2d6748.env
      # output-file          /private/tmp/ott-20250205-57949-b5rofy/ott-0.34/.opam/log/coq-stdlib-58087-2d6748.out
      ### output ###
      # [...]
      # 43 |  (action
      # 44 |   (with-stdout-to %{targets}
      # 45 |    (run tools/dune_rule_gen/gen_rules.exe Coq theories %{env:COQ_DUNE_EXTRA_OPT=}))))
      # (cd _build/default && tools/dune_rule_gen/gen_rules.exe Coq theories -split) > _build/default/theories_dune
      # [gen_rules] Fatal error: Invalid_argument("failed to locate Coq plugins in split build mode: coq-core.plugins.number_string_notation")
      # Raised at Coq_dune__Coq_rules.FlagUtil.findlib_plugin_flags in file "tools/dune_rule_gen/coq_rules.ml", line 56, characters 6-89
      # Called from Coq_dune__Coq_rules.FlagUtil.plugin_flags in file "tools/dune_rule_gen/coq_rules.ml" (inlined), line 59, characters 18-41
      # Called from Coq_dune__Coq_rules.Context.make in file "tools/dune_rule_gen/coq_rules.ml", line 189, characters 25-56
      # Called from Dune__exe__Gen_rules.main in file "tools/dune_rule_gen/gen_rules.ml", line 78, characters 13-101
      # Called from Dune__exe__Gen_rules in file "tools/dune_rule_gen/gen_rules.ml", line 104, characters 6-13
      # 
      # make: *** [.dune-stamp] Error 1
    
`brew test --retry --verbose comby` fails on macOS 14 and 15
==> /opt/homebrew/Cellar/comby/1.8.1_1/bin/comby 'printf(":[1] :[2]!")' 'printf("comby, :[1]!")' test.c -diff
  Uncaught exception:
"Assert_failure src/parany.ml:230:6"

Raised at Parany.run in file "src/parany.ml", line 230, characters 6-33 Called from Parany.Parmap.parfold in file "src/parany.ml", line 340, characters 6-87 Called from Pipeline.run in file "lib/app/pipeline/pipeline.ml", line 365, characters 37-91 Called from Dune__exe__Main.base_command_parameters.(fun) in file "src/main.ml", line 268, characters 6-32 Called from Core_kernel__Command.For_unix.run.(fun) in file "src/command.ml", line 2453, characters 8-238 Called from Base__Exn.handle_uncaught_aux in file "src/exn.ml", line 111, characters 6-10

bayandin avatar Feb 05 '25 20:02 bayandin

  • ppxlib requires https://github.com/ocaml-ppx/ppxlib/pull/558 to be merged
  • as for coq, likely it will need to wait for 9.0 (renamed into rocq): https://github.com/coq/coq/milestone/62

notxvilka avatar Feb 20 '25 16:02 notxvilka

Coq 9.0 (renamed into Rocq) is now released: https://github.com/coq/coq/releases/tag/V9.0.0 It should be updated first, probably.

Update: https://github.com/Homebrew/homebrew-core/pull/216253

notxvilka avatar Mar 19 '25 03:03 notxvilka

@daeho-ro @bayandin you forgot to bump the ppxlib revision (and possibly haxe as well) as well, just realised it wasn't in the changes. It should fix the problem, I think.

notxvilka avatar Jun 05 '25 06:06 notxvilka

zsh: /opt/homebrew/bin/camlp5: bad interpreter: /private/tmp/opamroot20250803-61859-47z0qk/default/bin/ocamlrun: no such file or directory

daeho-ro avatar Aug 03 '25 13:08 daeho-ro

Can ignore ott failure. Thought #234201 would fix it as worked for me locally. Low priority as only happens on source build and bottles are fine.

Probably can merge once CI is done.

cho-m avatar Aug 20 '25 19:08 cho-m

14-arm64 looks stuck (10 hours in while others finished in 1.5 hours). Will cancel and do one more run without source-build deps

cho-m avatar Aug 21 '25 04:08 cho-m

:robot: An automated task has requested bottles to be published to this PR.

[!CAUTION] Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch.

github-actions[bot] avatar Aug 21 '25 04:08 github-actions[bot]