homebrew-core icon indicating copy to clipboard operation
homebrew-core copied to clipboard

frankenphp 1.2.5 (new formula)

Open dunglas opened this issue 1 year ago • 3 comments
trafficstars

  • [x] Have you followed the guidelines for contributing?
  • [x] Have you ensured that your commits follow the commit style guide?
  • [x] Have you checked that there aren't other open pull requests for the same formula update/change?
  • [x] Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • [x] Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • [x] Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

This formula builds a static binary of FrankenPHP that embeds PHP. It's not possible to depend on the PHP provided by Brew because it doesn't provide libphp and it is not compiled with ZTS support, which is required for FrankenPHP.

It should be interesting to rebuild this formula when a new release of PHP is available, but I'm not sure of how to achieve this. Alternatively, it could be better to create a cask and download the static binary build each night upstream, that contains up-to-date versions of the dependencies.

dunglas avatar Oct 17 '24 04:10 dunglas

Thanks for contributing to Homebrew! :tada: It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

github-actions[bot] avatar Oct 17 '24 04:10 github-actions[bot]

Error: ../libtool: line 1733: x86_64-linux-musl-ar: command not found

stefanb avatar Oct 17 '24 04:10 stefanb

It's self-submitted, compiles it's own version of Homebrew formula, I think you should consider hosting it in a personal tap instead, which is very easy to do: https://docs.brew.sh/How-to-Create-and-Maintain-a-Tap

SMillerDev avatar Oct 17 '24 05:10 SMillerDev

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar Nov 07 '24 22:11 github-actions[bot]