homebrew-core icon indicating copy to clipboard operation
homebrew-core copied to clipboard

decasify 0.6.0 (new formula)

Open alerque opened this issue 1 year ago • 2 comments

Closes https://github.com/alerque/decasify/issues/22

alerque avatar Oct 15 '24 22:10 alerque

We frown on authors submitting their own work unless it is very popular.

https://docs.brew.sh/Acceptable-Formulae#niche-or-self-submitted-stuff

SMillerDev avatar Oct 16 '24 06:10 SMillerDev

We frown on authors submitting their own work unless it is very popular.

docs.brew.sh/Acceptable-Formulae#niche-or-self-submitted-stuff

I guess this is up to you guys to accept or reject. As a distro package maintainer myself (865 core Arch Linux packages, plus a smattering of Fedora, Nix, Homebrew, and other assorted packages) I understand the concern about maintainability and notoriety. I don't even use Homebrew myself and only submitted this at the request of a 3rd party user because I happened to know how to do it off the top of my head, but if is disqualified on notoriety grounds I'll look into setting up a tap or whatever is possible. As far as package maintainability, this shouldn't be a hard one given default autotools build options should just work as long as I'm doing things right upstream.

alerque avatar Oct 16 '24 11:10 alerque

  ==> make install
  /Applications/Xcode.app/Contents/Developer/usr/bin/make  install-am
   ./build-aux/install-sh -c -d '/opt/homebrew/Cellar/decasify/0.6.0/bin'
   ./build-aux/install-sh -c -d '/opt/homebrew/Cellar/decasify/0.6.0/share/doc/decasify'
   ./build-aux/install-sh -c -d '/opt/homebrew/Cellar/decasify/0.6.0/share/licenses/decasify'
   ./build-aux/install-sh -c -d '/opt/homebrew/Cellar/decasify/0.6.0/share/man/man1'
   /usr/bin/install -c -m 644 LICENSE.md '/opt/homebrew/Cellar/decasify/0.6.0/share/licenses/decasify'
   /usr/bin/install -c -m 644 README.md CHANGELOG.md '/opt/homebrew/Cellar/decasify/0.6.0/share/doc/decasify'
    /usr/bin/install -c decasify '/opt/homebrew/Cellar/decasify/0.6.0/bin'
   /usr/bin/install -c -m 644 decasify.1 '/opt/homebrew/Cellar/decasify/0.6.0/share/man/man1'
   ./build-aux/install-sh -c -d '/opt/homebrew/Cellar/decasify/0.6.0/share/bash-completion/completions'
   ./build-aux/install-sh -c -d '/opt/homebrew/Cellar/decasify/0.6.0/share/fish/vendor_completions.d'
   ./build-aux/install-sh -c -d '/opt/homebrew/Cellar/decasify/0.6.0/share/zsh/site-functions'
   /usr/bin/install -c -m 644 completions/decasify.fish '/opt/homebrew/Cellar/decasify/0.6.0/share/fish/vendor_completions.d'
   /usr/bin/install -c -m 644 completions/decasify '/opt/homebrew/Cellar/decasify/0.6.0/share/bash-completion/completions'
   /usr/bin/install -c -m 644 completions/_decasify '/opt/homebrew/Cellar/decasify/0.6.0/share/zsh/site-functions'
  Error: An exception occurred within a child process:
    NoMethodError: undefined method `each' for an instance of BuildEnvironment

chenrui333 avatar Oct 23 '24 20:10 chenrui333

@chenrui333 ~~I'm a little puzzled how to read that error, there are no instances of each or BuildEnvironment in the upstream project, so that's Homebrew's build system somewhere. The logged lines before that look like pretty normal make install-am output, I don't see an actual error there. It isn't clear if those lines succeeded or failed. Most of this built was adapted from the sile formula which happens to use a lot of the same autoconf macros for building Rust, installing shell completions, etc.~~ Fixed and passing tests; at least in CI the only error seems to be the notability check.

alerque avatar Oct 23 '24 21:10 alerque

Need to squash the commits in order to pass Commit style check.

cho-m avatar Nov 04 '24 15:11 cho-m

Sure, done.

But I don't understand the point of https://github.com/Homebrew/homebrew-core/labels/autosquash if PRs can't be be automatically squashed. :shrug:

alerque avatar Nov 04 '24 18:11 alerque

But I don't understand the point of https://github.com/Homebrew/homebrew-core/labels/autosquash if PRs can't be be automatically squashed. 🤷

They can, but the process is pretty annoying because we can't use GitHub's squash-and-merge feature (because we also need a bottle commit added)

carlocab avatar Nov 04 '24 18:11 carlocab

But I don't understand the point of autosquash Automatically squash pull request commits according to Homebrew style. if PRs can't be be automatically squashed. 🤷

They can, but the process is pretty annoying because we can't use GitHub's squash-and-merge feature (because we also need a bottle commit added)

I see. Given that "allow edits by maintainers" is checked by default more often these days couldn't CI automation take an approved PR that it is about to merge anyway, and squash it in the branch right before it adds the bottle commit, then push and merge?

alerque avatar Nov 04 '24 19:11 alerque