homebrew-core icon indicating copy to clipboard operation
homebrew-core copied to clipboard

LocalAI 2.21.1 (new formula)

Open mauromorales opened this issue 1 year ago • 2 comments

This introduces the formula for LocalAI https://localai.io/ the free, Open Source OpenAI alternative. Self-hosted, community-driven and local-first

Supersedes #172734

  • [x] Have you followed the guidelines for contributing?
  • [x] Have you ensured that your commits follow the commit style guide?
  • [x] Have you checked that there aren't other open pull requests for the same formula update/change?
  • [x] Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • [x] Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • [x] Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

mauromorales avatar Oct 07 '24 07:10 mauromorales

@SMillerDev only the commit of the suggestion is not passing, but since it will be autosquashed that should not be a problem I'd assume. Or do I need to squash them manually?

mauromorales avatar Oct 07 '24 15:10 mauromorales

Hi @SMillerDev @chenrui333,

I’m a bit confused about how the review process for this Formula is progressing. It feels like many of the issues raised could have been addressed earlier, perhaps during the initial review of this PR or even in the previous attempt to merge it https://github.com/Homebrew/homebrew-core/pull/172734.

Just to clarify, I’m not a developer at LocalAI—I’m simply a user trying to contribute to the project by making installation on Mac easier via Homebrew. However, I’m not an expert in Python, macOS, LocalAI, or Homebrew, so some of the technical issues raised are beyond my expertise.

I’m more than willing to make changes if I understand exactly what’s needed. At the moment, the back-and-forth process feels inefficient, and I would appreciate more guidance to help me move this forward. I opened the original PR back in May, and I think we could have made more progress by now.

I understand you’re likely very busy, so I’m not demanding anything here—just asking for some support if you’re able to provide it. If not, I may need to consider closing this PR since I don’t have unlimited time to keep working on it without clear direction. The current formula works fine for me, and I’m able to run LocalAI on my own machine. My goal was simply to make things easier for the community, and I still believe this would benefit from being part of Homebrew. That said, I’m happy for someone with more expertise to take over and improve it in the future.

Thanks again for your time, and I look forward to your feedback.

mauromorales avatar Oct 14 '24 10:10 mauromorales

we dont do merge commit, rather it should be done as rebase.

chenrui333 avatar Oct 22 '24 04:10 chenrui333

:shipit: @chenrui333 has requested bottles to be published to this PR.

github-actions[bot] avatar Oct 23 '24 15:10 github-actions[bot]

@mauromorales, thanks for your first contribution to Homebrew! :tada: 🥇

Without awesome contributors like you, it would be impossible to maintain Homebrew to the high level of quality users have come to expect. Thank you!!!!

chenrui333 avatar Oct 23 '24 15:10 chenrui333

thank you for the help @chenrui333

mauromorales avatar Oct 23 '24 17:10 mauromorales