homebrew-core icon indicating copy to clipboard operation
homebrew-core copied to clipboard

paperjam 1.2 (new formula)

Open jvns opened this issue 1 year ago • 3 comments

  • [x] Have you followed the guidelines for contributing?
  • [x] Have you ensured that your commits follow the commit style guide?
  • [x] Have you checked that there aren't other open pull requests for the same formula update/change?
  • [x] Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • [x] Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • [x] Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Paperjam is a tool I use for transforming PDFs, would love to have it in Homebrew!

jvns avatar Aug 20 '24 12:08 jvns

Thanks for contributing to Homebrew! :tada: It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

github-actions[bot] avatar Aug 20 '24 12:08 github-actions[bot]

The build works on my Mac but is failing on Linux in CI with this error:

g++-11 -O2 -Wall -Wextra -Wno-parentheses -std=gnu++11 -g   -c -o cmds.o cmds.cc
  In file included from /home/linuxbrew/.linuxbrew/include/qpdf/QPDF.hh:44,
                   from pdf-tools.h:13,
                   from jam.h:37,
                   from parse.cc:12:
  /home/linuxbrew/.linuxbrew/include/qpdf/QPDFWriter.hh:482:27: error: ‘std::string_view’ has not been declared
    482 |     void writeString(std::string_view str);
        |                           ^~~~~~~~~~~

From Googling it seems like it's failing because it needs a feature from C++17 but I'm not sure how to fix that in the homebrew context (or at all really).

jvns avatar Aug 20 '24 19:08 jvns

a2x: ERROR: "xmllint" --nonet --noout --valid "/tmp/paperjam-20240821-11487-282qnk/paperjam-1.2/paperjam.1.xml" returned non-zero exit status 127

SMillerDev avatar Aug 22 '24 08:08 SMillerDev

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar Sep 18 '24 00:09 github-actions[bot]

The error I'm seeing now is:

Formulae should not require patches to build. Patches should be submitted and accepted upstream first.

The patch is from upstream but isn't included in the latest release. Not sure how likely upstream is to make a new release since the last release was in 2022.

jvns avatar Sep 18 '24 01:09 jvns

The patch is from upstream but isn't included in the latest release. Not sure how likely upstream is to make a new release since the last release was in 2022.

Could you ask upstream for a release? No release in 2 years also makes it seem pretty much unmaintained.

SMillerDev avatar Sep 18 '24 08:09 SMillerDev

I emailed the maintainer and he made a new release, updated the PR to remove the patch and use the new release.

jvns avatar Oct 04 '24 13:10 jvns

:robot: An automated task has requested bottles to be published to this PR.

github-actions[bot] avatar Oct 04 '24 14:10 github-actions[bot]