homebrew-core
homebrew-core copied to clipboard
quazip: skip linux ci test
- [ ] Have you followed the guidelines for contributing?
- [ ] Have you ensured that your commits follow the commit style guide?
- [ ] Have you checked that there aren't other open pull requests for the same formula update/change?
- [ ] Have you built your formula locally with
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting? - [ ] Is your test running fine
brew test <formula>, where<formula>is the name of the formula you're submitting? - [ ] Does your build pass
brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?
quazip consistently failed on linux, but cannot be reproduced when I tried build/testing on github linux runner, so suggesting to skip the linux CI test.
current linux CI test failure
==> Testing quazip
==> /home/linuxbrew/.linuxbrew/opt/qt/bin/qmake test.pro
Info: creating stash file /tmp/quazip-test-20240801-545257-lmel3j/.qmake.stash
==> make
g++ -c -pipe -O2 -Wall -Wextra -fPIC -D_REENTRANT -DQT_NO_DEBUG -DQT_GUI_LIB -DQT_CORE_LIB -I. -I/home/linuxbrew/.linuxbrew/Cellar/quazip/1.4/include -I/home/linuxbrew/.linuxbrew/Cellar/qt/6.7.0_1/include -I/home/linuxbrew/.linuxbrew/Cellar/qt/6.7.0_1/include/QtGui -I/home/linuxbrew/.linuxbrew/Cellar/qt/6.7.0_1/include/QtCore -I. -I/home/linuxbrew/.linuxbrew/Cellar/qt/6.7.0_1/share/qt/mkspecs/linux-g++ -o test.o test.cpp
In file included from /home/linuxbrew/.linuxbrew/Cellar/quazip/1.4/include/quazip/quazip.h:32,
from test.cpp:1:
/home/linuxbrew/.linuxbrew/Cellar/quazip/1.4/include/quazip/zip.h:56:10: fatal error: zlib.h: No such file or directory
56 | #include <zlib.h>
| ^~~~~~~~
compilation terminated.
make: *** [Makefile:1289: test.o] Error 1
quazip consistently failed on linux, but cannot be reproduced when I tried build/testing on github linux runner, so suggesting to skip the linux CI test.
Does the runner have system zlib installed?
I am guessing test needs to be updated to properly find brew zlib.
quazip consistently failed on linux, but cannot be reproduced when I tried build/testing on github linux runner, so suggesting to skip the linux CI test.
Does the runner have system
zlibinstalled?
I dont see zlib installed, the brew test works out fine without zlib formula
runner@fv-az1116-644:~/work/github-action-test/github-action-test$ brew list zlib
Error: No such keg: /home/linuxbrew/.linuxbrew/Cellar/zlib
::error::No such keg: /home/linuxbrew/.linuxbrew/Cellar/zlib
runner@fv-az1116-644:~/work/github-action-test/github-action-test$ brew test -d -v quazip
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/portable-ruby/3.3.4/bin/bundle clean
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.rb (Formulary::FromNameLoader): loading quazip
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.rb (Formulary::FromTapLoader): loading homebrew/core/quazip
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.rb (Formulary::FromNameLoader): loading cmake
/usr/bin/env /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/shims/shared/git --version
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.rb (Formulary::FromNameLoader): loading qt
==> Testing quazip
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/test.rb (Formulary::FromPathLoader): loading /home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/q/quazip.rb
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/test.rb (Formulary::FromNameLoader): loading gcc@11
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/test.rb (Formulary::FromNameLoader): loading qt
/usr/bin/env /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/shims/shared/git --version
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/test.rb (Formulary::FromNameLoader): loading qt
==> /home/linuxbrew/.linuxbrew/opt/qt/bin/qmake test.pro
Info: creating stash file /tmp/quazip-test-20240801-46557-cy5w91/.qmake.stash
==> make
g++ -c -pipe -O2 -Wall -Wextra -fPIC -D_REENTRANT -DQT_NO_DEBUG -DQT_GUI_LIB -DQT_CORE_LIB -I. -I/home/linuxbrew/.linuxbrew/Cellar/quazip/1.4/include -I/home/linuxbrew/.linuxbrew/Cellar/qt/6.7.0_1/include -I/home/linuxbrew/.linuxbrew/Cellar/qt/6.7.0_1/include/QtGui -I/home/linuxbrew/.linuxbrew/Cellar/qt/6.7.0_1/include/QtCore -I. -I/home/linuxbrew/.linuxbrew/Cellar/qt/6.7.0_1/share/qt/mkspecs/linux-g++ -o test.o test.cpp
g++ -Wl,-O1 -Wl,-rpath,/home/linuxbrew/.linuxbrew/Cellar/quazip/1.4/lib -Wl,-rpath,/home/linuxbrew/.linuxbrew/Cellar/qt/6.7.0_1/lib -Wl,-rpath-link,/home/linuxbrew/.linuxbrew/Cellar/qt/6.7.0_1/lib -o test test.o -L/home/linuxbrew/.linuxbrew/Cellar/quazip/1.4/lib -lquazip1-qt6 /home/linuxbrew/.linuxbrew/Cellar/qt/6.7.0_1/lib/libQt6Gui.so /home/linuxbrew/.linuxbrew/Cellar/qt/6.7.0_1/lib/libQt6Core.so -lpthread -lGL
==> ./test
Brew zlib is a dependency of qt so it should be installed. System zlib may be installed on runner in some situations, though not if using Homebrew's docker image
quazip has a hard dependency on zlib, e.g.
- quazip/1.4/lib/pkgconfig/quazip1-qt6.pc
Requires: zlib, Qt6Core - quazip/1.4/lib/cmake/QuaZip-Qt6-1.4/QuaZip-Qt6Config.cmake
if(OFF) find_dependency(Qt6 REQUIRED COMPONENTS Zlib) else() find_dependency(ZLIB REQUIRED) endif()
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.